From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] Readline bug causes GDB crash on 64-bit
Date: Sat, 21 Oct 2006 05:15:00 -0000 [thread overview]
Message-ID: <20061021051501.GA27102@nevyn.them.org> (raw)
In-Reply-To: <200610202110.k9KLAiFL002481@d12av02.megacenter.de.ibm.com>
On Fri, Oct 20, 2006 at 11:10:43PM +0200, Ulrich Weigand wrote:
> Hello,
>
> GDB on s390x (64-bit) is crashing when you press ctrl-V.
> This is because xmalloc is used without prototype in scope
> in _rl_callback_data_alloc (readline/callback.c), and thus
> the returned pointer is improperly truncated/extended.
>
> Fixed by including "xmalloc.h". Tested on s390x-ibm-linux.
>
> What's the policy for readline bugs in GDB? It is OK to check
> this patch into GDB, or does it have to go upstream first?
> (Where is readline upstream?)
I don't want to mess with a readline import just now. So, unless you
want to try it, this patch is fine for now.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-10-21 5:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-20 21:10 Ulrich Weigand
2006-10-20 21:30 ` Andreas Schwab
2006-10-20 21:36 ` Daniel Jacobowitz
2006-10-20 21:32 ` Daniel Jacobowitz
2006-10-21 2:56 ` Chet Ramey
2006-10-21 5:15 ` Daniel Jacobowitz [this message]
2006-10-21 20:48 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061021051501.GA27102@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox