From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21679 invoked by alias); 21 Oct 2006 05:15:07 -0000 Received: (qmail 21475 invoked by uid 22791); 21 Oct 2006 05:15:05 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 21 Oct 2006 05:15:02 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Gb9CH-00073s-4b for gdb-patches@sourceware.org; Sat, 21 Oct 2006 01:15:01 -0400 Date: Sat, 21 Oct 2006 05:15:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [PATCH] Readline bug causes GDB crash on 64-bit Message-ID: <20061021051501.GA27102@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <200610202110.k9KLAiFL002481@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200610202110.k9KLAiFL002481@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00266.txt.bz2 On Fri, Oct 20, 2006 at 11:10:43PM +0200, Ulrich Weigand wrote: > Hello, > > GDB on s390x (64-bit) is crashing when you press ctrl-V. > This is because xmalloc is used without prototype in scope > in _rl_callback_data_alloc (readline/callback.c), and thus > the returned pointer is improperly truncated/extended. > > Fixed by including "xmalloc.h". Tested on s390x-ibm-linux. > > What's the policy for readline bugs in GDB? It is OK to check > this patch into GDB, or does it have to go upstream first? > (Where is readline upstream?) I don't want to mess with a readline import just now. So, unless you want to try it, this patch is fine for now. -- Daniel Jacobowitz CodeSourcery