From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29705 invoked by alias); 21 Oct 2006 02:56:40 -0000 Received: (qmail 29696 invoked by uid 22791); 21 Oct 2006 02:56:40 -0000 X-Spam-Check-By: sourceware.org Received: from mpv3.TIS.CWRU.Edu (HELO mpv3.TIS.cwru.edu) (129.22.105.35) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 21 Oct 2006 02:56:36 +0000 Received: from [192.168.1.101] ([71.31.156.34]) by mpv3.TIS.cwru.edu (MOS 3.7.5-GA) with ESMTP id BJN64517 (AUTH cpr); Fri, 20 Oct 2006 22:55:09 -0400 (EDT) Message-ID: <45398C0C.9090202@case.edu> Date: Sat, 21 Oct 2006 02:56:00 -0000 From: Chet Ramey Reply-To: chet.ramey@case.edu User-Agent: Thunderbird 1.5.0.7 (Macintosh/20060909) MIME-Version: 1.0 To: Ulrich Weigand , gdb-patches@sourceware.org CC: chet@case.edu Subject: Re: [PATCH] Readline bug causes GDB crash on 64-bit References: <200610202110.k9KLAiFL002481@d12av02.megacenter.de.ibm.com> <20061020213228.GA14966@nevyn.them.org> In-Reply-To: <20061020213228.GA14966@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00265.txt.bz2 Daniel Jacobowitz wrote: > On Fri, Oct 20, 2006 at 11:10:43PM +0200, Ulrich Weigand wrote: >> Hello, >> >> GDB on s390x (64-bit) is crashing when you press ctrl-V. >> This is because xmalloc is used without prototype in scope >> in _rl_callback_data_alloc (readline/callback.c), and thus >> the returned pointer is improperly truncated/extended. >> >> Fixed by including "xmalloc.h". Tested on s390x-ibm-linux. >> >> What's the policy for readline bugs in GDB? It is OK to check >> this patch into GDB, or does it have to go upstream first? >> (Where is readline upstream?) > > The right thing to do is to send the patch to Chet, and if he accepts > it for the next readline release, commit it to our copy. I believe > bash-maintainers@gnu.org (CC'd) is the right place. Either that address or bug-readline@gnu.org will work. But in this case, someone beat you to it, and the fix is in the recently-released readline-5.2. Chet -- ``The lyf so short, the craft so long to lerne.'' - Chaucer Live Strong. No day but today. Chet Ramey, ITS, CWRU chet@case.edu http://cnswww.cns.cwru.edu/~chet/