From: Simon Marchi <simark@simark.ca>
To: "Strasuns, Mihails" <mihails.strasuns@intel.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3 4/9] [gdb/testsuite] use args as lib list for jit-elf tests
Date: Mon, 20 Apr 2020 09:08:23 -0400 [thread overview]
Message-ID: <449eed20-ca92-e3fe-5d42-30750e28043e@simark.ca> (raw)
In-Reply-To: <MWHPR11MB00486A459FEFBC271E2D07E895D40@MWHPR11MB0048.namprd11.prod.outlook.com>
On 2020-04-20 3:35 a.m., Strasuns, Mihails wrote:
>> -----Original Message-----
>> From: Simon Marchi <simark@simark.ca>
>> Sent: Saturday, April 18, 2020 4:58 AM
>> To: Strasuns, Mihails <mihails.strasuns@intel.com>; gdb-
>> patches@sourceware.org
>> Subject: Re: [PATCH v3 4/9] [gdb/testsuite] use args as lib list for jit-elf tests
>
>
>>> @@ -146,31 +149,23 @@ proc one_jit_test {count match_str reattach} {
>>> }
>>> }
>>>
>>> -if {[compile_jit_test jit.exp "" {}] < 0} {
>>> - return
>>> -}
>>> -one_jit_test 1 "${hex} jit_function_0000" 0 -one_jit_test 2 "${hex}
>>> jit_function_0000\[\r\n\]+${hex} jit_function_0001" 0
>>> +compile_jit_main "" {}
>>> +compile_n_jit_so 2
>>
>> I mentioned ealier: if we fail to compile the test program, we don't want to
>> execute the rest of the test case. That's what the previous code did. Can
>> you keep that?
>>
>> Simon
>
> I have added it as a separate patch in the series (see "[PATCH v3 9/9] [gdb/testsuite] handle compilation failures in jit-elf-helpers") as it seemed more incremental / easier to read. Is that ok?
I don't know, the code before this patch does the checks already, which you remove in this
patch. Is there some difficulty in just keeping it?
Simon
next prev parent reply other threads:[~2020-04-20 13:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166773>
2020-03-31 17:13 ` [PATCH v3 1/9] [gdb/testsuite] allow more registers in reader test Mihails Strasuns
2020-03-31 17:13 ` [PATCH v3 2/9] [gdb/testsuite] structured rename of jit test files Mihails Strasuns
2020-04-18 2:35 ` Simon Marchi
2020-03-31 17:13 ` [PATCH v3 3/9] [gdb/testsuite] share jit-protocol.h by all jit tests Mihails Strasuns
2020-04-18 2:38 ` Simon Marchi
2020-03-31 17:13 ` [PATCH v3 4/9] [gdb/testsuite] use args as lib list for jit-elf tests Mihails Strasuns
2020-04-18 2:58 ` Simon Marchi
2020-04-20 7:35 ` Strasuns, Mihails
2020-04-20 13:08 ` Simon Marchi [this message]
2020-04-20 13:53 ` Simon Marchi
2020-03-31 17:13 ` [PATCH v3 5/9] [gdb/testsuite] add lib/jit-elf-helpers.exp Mihails Strasuns
2020-03-31 17:13 ` [PATCH v3 6/9] [gdb/testsuite] use -Ttext-segment for jit-elf tests Mihails Strasuns
2020-03-31 17:13 ` [PATCH v3 7/9] [gdb/testsuite] define jit function name via macro Mihails Strasuns
2020-03-31 17:13 ` [PATCH v3 8/9] [gdb/testsuite] add jit-elf-util.h and run jit function Mihails Strasuns
2020-03-31 17:13 ` [PATCH v3 9/9] [gdb/testsuite] handle compilation failures in jit-elf-helpers Mihails Strasuns
2020-04-14 10:08 ` [PATCH v3 1/9] [gdb/testsuite] allow more registers in reader test Strasuns, Mihails
2020-04-18 2:30 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449eed20-ca92-e3fe-5d42-30750e28043e@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=mihails.strasuns@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox