RE: [PATCH v3 4/9] [gdb/testsuite] use args as lib list for jit-elf tests

["Strasuns, Mihails" <mihails.strasuns@intel.com>]

> -----Original Message-----
> From: Simon Marchi <simark@simark.ca>
> Sent: Saturday, April 18, 2020 4:58 AM
> To: Strasuns, Mihails <mihails.strasuns@intel.com>; gdb-
> patches@sourceware.org
> Subject: Re: [PATCH v3 4/9] [gdb/testsuite] use args as lib list for jit-elf tests


> > @@ -146,31 +149,23 @@ proc one_jit_test {count match_str reattach} {
> >      }
> >  }
> >
> > -if {[compile_jit_test jit.exp "" {}] < 0} {
> > -    return
> > -}
> > -one_jit_test 1 "${hex}  jit_function_0000" 0 -one_jit_test 2 "${hex}
> > jit_function_0000\[\r\n\]+${hex}  jit_function_0001" 0
> > +compile_jit_main "" {}
> > +compile_n_jit_so 2
> 
> I mentioned ealier: if we fail to compile the test program, we don't want to
> execute the rest of the test case.  That's what the previous code did.  Can
> you keep that?
> 
> Simon

I have added it as a separate patch in the series (see "[PATCH v3 9/9] [gdb/testsuite] handle compilation failures in jit-elf-helpers") as it seemed more incremental / easier to read.  Is that ok?

BR,
Mihails
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928