From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 187B2384B104 for ; Mon, 20 Apr 2020 13:08:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 187B2384B104 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 626FA1E581; Mon, 20 Apr 2020 09:08:24 -0400 (EDT) Subject: Re: [PATCH v3 4/9] [gdb/testsuite] use args as lib list for jit-elf tests To: "Strasuns, Mihails" , "gdb-patches@sourceware.org" References: <166773> <20200331171356.26126-1-mihails.strasuns@intel.com> <20200331171356.26126-4-mihails.strasuns@intel.com> <49eaa7a6-b124-c15b-b1fe-17a7d72833ff@simark.ca> From: Simon Marchi Message-ID: <449eed20-ca92-e3fe-5d42-30750e28043e@simark.ca> Date: Mon, 20 Apr 2020 09:08:23 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, GIT_PATCH_2, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2020 13:08:29 -0000 On 2020-04-20 3:35 a.m., Strasuns, Mihails wrote: >> -----Original Message----- >> From: Simon Marchi >> Sent: Saturday, April 18, 2020 4:58 AM >> To: Strasuns, Mihails ; gdb- >> patches@sourceware.org >> Subject: Re: [PATCH v3 4/9] [gdb/testsuite] use args as lib list for jit-elf tests > > >>> @@ -146,31 +149,23 @@ proc one_jit_test {count match_str reattach} { >>> } >>> } >>> >>> -if {[compile_jit_test jit.exp "" {}] < 0} { >>> - return >>> -} >>> -one_jit_test 1 "${hex} jit_function_0000" 0 -one_jit_test 2 "${hex} >>> jit_function_0000\[\r\n\]+${hex} jit_function_0001" 0 >>> +compile_jit_main "" {} >>> +compile_n_jit_so 2 >> >> I mentioned ealier: if we fail to compile the test program, we don't want to >> execute the rest of the test case. That's what the previous code did. Can >> you keep that? >> >> Simon > > I have added it as a separate patch in the series (see "[PATCH v3 9/9] [gdb/testsuite] handle compilation failures in jit-elf-helpers") as it seemed more incremental / easier to read. Is that ok? I don't know, the code before this patch does the checks already, which you remove in this patch. Is there some difficulty in just keeping it? Simon