From: Nathan Sidwell <nathan@codesourcery.com>
To: Nathan Sidwell <nathan@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Add system(NULL) to fileio
Date: Tue, 13 Jun 2006 13:29:00 -0000 [thread overview]
Message-ID: <448EBD93.1050804@codesourcery.com> (raw)
In-Reply-To: <4489D824.40605@codesourcery.com>
Nathan Sidwell wrote:
> ------------------------------------------------------------------------
>
> 2006-06-09 Nathan Sidwell <nathan@codesourcery.com>
>
> gdb/
> * remote-file.io.c (remote_fileio_func_system): Treat zero length
> string as NULL. Adjust for NULL pointer argument.
> * doc/gdb.texinfo (system): Document behaviour with zero length
> string.
>
> gdb/testsuite/
> * gdb.base/fileio.c: Add system(NULL) test.
> * gdb.base/fileio.exp: Check it.
I applied the patch with the suggested changes to documentation and comment.
Daniel pointed out that I'd misunderstood Eli's email as only approving the
documentation change, but he has told me the patch is good.
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery
nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk
prev parent reply other threads:[~2006-06-13 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-09 20:21 Nathan Sidwell
2006-06-10 7:37 ` Eli Zaretskii
2006-06-10 11:52 ` Nathan Sidwell
2006-06-10 21:40 ` Eli Zaretskii
2006-06-12 12:11 ` Corinna Vinschen
2006-06-13 8:31 ` Nathan Sidwell
2006-06-13 13:29 ` Nathan Sidwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=448EBD93.1050804@codesourcery.com \
--to=nathan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox