From: Nathan Sidwell <nathan@codesourcery.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: Add system(NULL) to fileio
Date: Sat, 10 Jun 2006 11:52:00 -0000 [thread overview]
Message-ID: <448AB24C.1090106@codesourcery.com> (raw)
In-Reply-To: <u3bedqx5h.fsf@gnu.org>
Eli Zaretskii wrote:
>> *** gdb/testsuite/gdb.base/fileio.c 5 Jun 2006 15:36:02 -0000 1.8.12.1
>> --- gdb/testsuite/gdb.base/fileio.c 9 Jun 2006 15:12:57 -0000
>> *************** test_system ()
>> *** 385,390 ****
>> --- 385,394 ----
>> ret = system ("wrtzlpfrmpft");
>> printf ("system 2: ret = %d %s\n", ret, WEXITSTATUS (ret) == 127 ? "OK" : "");
>> stop ();
>> + /* Test for shell */
>> + ret = system (NULL);
>> + printf ("system 3: ret = %d %s\n", ret, ret != 0 ? "OK" : "");
>> + stop ();
>
> Isn't it better to test for shell availability _before_ we send it
> commands, not after?
Sure. I just didn't want to disturb the testcase more. I can reorder it :)
Can you look at my 'Remove some spurious test fails' because, amongst other
things it makes it tractable to go alter the fileio testcase.
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery
nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk
next prev parent reply other threads:[~2006-06-10 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-09 20:21 Nathan Sidwell
2006-06-10 7:37 ` Eli Zaretskii
2006-06-10 11:52 ` Nathan Sidwell [this message]
2006-06-10 21:40 ` Eli Zaretskii
2006-06-12 12:11 ` Corinna Vinschen
2006-06-13 8:31 ` Nathan Sidwell
2006-06-13 13:29 ` Nathan Sidwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=448AB24C.1090106@codesourcery.com \
--to=nathan@codesourcery.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox