From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19845 invoked by alias); 10 Jun 2006 11:52:55 -0000 Received: (qmail 19832 invoked by uid 22791); 10 Jun 2006 11:52:54 -0000 X-Spam-Check-By: sourceware.org Received: from potter.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 10 Jun 2006 11:51:50 +0000 Received: (qmail 15170 invoked from network); 10 Jun 2006 11:51:48 -0000 Received: from unknown (HELO ?192.168.189.148?) (nathan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 10 Jun 2006 11:51:48 -0000 Message-ID: <448AB24C.1090106@codesourcery.com> Date: Sat, 10 Jun 2006 11:52:00 -0000 From: Nathan Sidwell User-Agent: Thunderbird 1.5.0.2 (X11/20060522) MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org Subject: Re: Add system(NULL) to fileio References: <4489D824.40605@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00122.txt.bz2 Eli Zaretskii wrote: >> *** gdb/testsuite/gdb.base/fileio.c 5 Jun 2006 15:36:02 -0000 1.8.12.1 >> --- gdb/testsuite/gdb.base/fileio.c 9 Jun 2006 15:12:57 -0000 >> *************** test_system () >> *** 385,390 **** >> --- 385,394 ---- >> ret = system ("wrtzlpfrmpft"); >> printf ("system 2: ret = %d %s\n", ret, WEXITSTATUS (ret) == 127 ? "OK" : ""); >> stop (); >> + /* Test for shell */ >> + ret = system (NULL); >> + printf ("system 3: ret = %d %s\n", ret, ret != 0 ? "OK" : ""); >> + stop (); > > Isn't it better to test for shell availability _before_ we send it > commands, not after? Sure. I just didn't want to disturb the testcase more. I can reorder it :) Can you look at my 'Remove some spurious test fails' because, amongst other things it makes it tractable to go alter the fileio testcase. nathan -- Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk