From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11025 invoked by alias); 13 Jun 2006 13:29:41 -0000 Received: (qmail 11016 invoked by uid 22791); 13 Jun 2006 13:29:40 -0000 X-Spam-Check-By: sourceware.org Received: from potter.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 13 Jun 2006 13:29:39 +0000 Received: (qmail 28774 invoked from network); 13 Jun 2006 13:29:37 -0000 Received: from unknown (HELO ?192.168.189.145?) (nathan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 13 Jun 2006 13:29:37 -0000 Message-ID: <448EBD93.1050804@codesourcery.com> Date: Tue, 13 Jun 2006 13:29:00 -0000 From: Nathan Sidwell User-Agent: Mozilla Thunderbird 1.0.8 (X11/20060502) MIME-Version: 1.0 To: Nathan Sidwell CC: gdb-patches@sourceware.org Subject: Re: Add system(NULL) to fileio References: <4489D824.40605@codesourcery.com> In-Reply-To: <4489D824.40605@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00181.txt.bz2 Nathan Sidwell wrote: > ------------------------------------------------------------------------ > > 2006-06-09 Nathan Sidwell > > gdb/ > * remote-file.io.c (remote_fileio_func_system): Treat zero length > string as NULL. Adjust for NULL pointer argument. > * doc/gdb.texinfo (system): Document behaviour with zero length > string. > > gdb/testsuite/ > * gdb.base/fileio.c: Add system(NULL) test. > * gdb.base/fileio.exp: Check it. I applied the patch with the suggested changes to documentation and comment. Daniel pointed out that I'd misunderstood Eli's email as only approving the documentation change, but he has told me the patch is good. nathan -- Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk