Re: [PATCH 1/2] Split gdb.multi/multi-target.exp into separate testcases

[Pedro Alves <pedro@palves.net>]

On 9/17/20 8:16 PM, Simon Marchi wrote:
> On 2020-09-17 2:00 p.m., Pedro Alves wrote:
>> gdb.multi/multi-target.exp sets up a debug environment with multiple
>> gdbservers, multiple native processes, and multiple cores, which has
>> proved useful for exercising a number of multi-target scenarios.
>>
>> But, as we add more tests to gdb.base/multi-target.exp, it is growing
>> a bit too large (making a bit cumbersome to debug) and too slow to run
>> (if you have glibc debug info).
>>
>> This commit thus splits the multi-target.exp into several testcases,
>> one per use case.  The common setup code is moved to a new
>> multi-target.exp.tcl file that is included by all the resulting
>> multi-target testcases.
> 
> Nice, that makes the test cases much more readable too.

I agree.

>> +    # We're use inferiors 1 and 2.  Make sure they're really connected
> 
> I just spotted this typo: "use" -> "using".

I think I originally meant to say "We'll use".  I fixed it to use that.