From: Simon Marchi <simark@simark.ca>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Split gdb.multi/multi-target.exp into separate testcases
Date: Thu, 17 Sep 2020 15:41:16 -0400 [thread overview]
Message-ID: <32ae5490-6e6e-0c82-f5a7-7675ea33b997@simark.ca> (raw)
In-Reply-To: <20200917180038.29226-2-pedro@palves.net>
On 2020-09-17 2:00 p.m., Pedro Alves wrote:
> gdb.multi/multi-target.exp sets up a debug environment with multiple
> gdbservers, multiple native processes, and multiple cores, which has
> proved useful for exercising a number of multi-target scenarios.
>
> But, as we add more tests to gdb.base/multi-target.exp, it is growing
> a bit too large (making a bit cumbersome to debug) and too slow to run
> (if you have glibc debug info).
>
> This commit thus splits the multi-target.exp into several testcases,
> one per use case. The common setup code is moved to a new
> multi-target.exp.tcl file that is included by all the resulting
> multi-target testcases.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.multi/mtarg-continue.exp: New file, factored out from
> multi-target.exp.
> * gdb.multi/mtarg-info-inferiors.exp: New file, factored out from
> multi-target.exp.
> * gdb.multi/mtarg-interrupt.exp: New file, factored out from
> multi-target.exp.
> * gdb.multi/mtarg-no-resumed.exp: New file, factored out from
> multi-target.exp.
> * gdb.multi/mtarg-ping-pong-next.exp: New file, factored out from
> multi-target.exp.
> * gdb.multi/multi-target.exp.tcl: New file, factored out from
> multi-target.exp.
> * gdb.multi/multi-target.exp: Delete.
Maybe a small comment here: I think it would be clearer to not
abbreviate "multi-target" to "mtarg", so to name the files
"multi-target-foo.exp". Abbreviations like that are a bit intimidating
when you are not familiar with them.
Simon
next prev parent reply other threads:[~2020-09-17 19:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 18:00 [PATCH 0/2] Fix "thread find" with multi inferior/target (PR gdb/26631) Pedro Alves
2020-09-17 18:00 ` [PATCH 1/2] Split gdb.multi/multi-target.exp into separate testcases Pedro Alves
2020-09-17 19:16 ` Simon Marchi
2020-09-18 12:34 ` Pedro Alves
2020-09-17 19:41 ` Simon Marchi [this message]
2020-09-18 13:01 ` Pedro Alves
2020-09-17 18:00 ` [PATCH 2/2] Fix "thread find" with multiple inferiors/targets (PR gdb/26631) Pedro Alves
2020-09-17 19:37 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32ae5490-6e6e-0c82-f5a7-7675ea33b997@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox