From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 01D753861012 for ; Thu, 17 Sep 2020 19:41:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 01D753861012 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A52151E50D; Thu, 17 Sep 2020 15:41:16 -0400 (EDT) Subject: Re: [PATCH 1/2] Split gdb.multi/multi-target.exp into separate testcases To: Pedro Alves , gdb-patches@sourceware.org References: <20200917180038.29226-1-pedro@palves.net> <20200917180038.29226-2-pedro@palves.net> From: Simon Marchi Message-ID: <32ae5490-6e6e-0c82-f5a7-7675ea33b997@simark.ca> Date: Thu, 17 Sep 2020 15:41:16 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200917180038.29226-2-pedro@palves.net> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2020 19:41:18 -0000 On 2020-09-17 2:00 p.m., Pedro Alves wrote: > gdb.multi/multi-target.exp sets up a debug environment with multiple > gdbservers, multiple native processes, and multiple cores, which has > proved useful for exercising a number of multi-target scenarios. > > But, as we add more tests to gdb.base/multi-target.exp, it is growing > a bit too large (making a bit cumbersome to debug) and too slow to run > (if you have glibc debug info). > > This commit thus splits the multi-target.exp into several testcases, > one per use case. The common setup code is moved to a new > multi-target.exp.tcl file that is included by all the resulting > multi-target testcases. > > gdb/testsuite/ChangeLog: > > * gdb.multi/mtarg-continue.exp: New file, factored out from > multi-target.exp. > * gdb.multi/mtarg-info-inferiors.exp: New file, factored out from > multi-target.exp. > * gdb.multi/mtarg-interrupt.exp: New file, factored out from > multi-target.exp. > * gdb.multi/mtarg-no-resumed.exp: New file, factored out from > multi-target.exp. > * gdb.multi/mtarg-ping-pong-next.exp: New file, factored out from > multi-target.exp. > * gdb.multi/multi-target.exp.tcl: New file, factored out from > multi-target.exp. > * gdb.multi/multi-target.exp: Delete. Maybe a small comment here: I think it would be clearer to not abbreviate "multi-target" to "mtarg", so to name the files "multi-target-foo.exp". Abbreviations like that are a bit intimidating when you are not familiar with them. Simon