From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by sourceware.org (Postfix) with ESMTPS id 0EEA2384A01C for ; Fri, 18 Sep 2020 12:34:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0EEA2384A01C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f67.google.com with SMTP id k18so5404010wmj.5 for ; Fri, 18 Sep 2020 05:34:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hl4hmpJb07R+01perxxg4swZf9YhKPGwpTk2s/nvv6w=; b=MCehrkDHKXTLxEMCJL399tiyFrdek0q0udcQmS6nhqteP+AdtINNHcf6lMsWOcju83 NUzZD6VIoTK/aNJ1nTCK/y0JkZPbOdHYfswhwaxG5Qu2OhFdlTq2TnlP05gXg+t6DOiw gVrzTU+fU1zcGsv6AkkZAFDjn4Ld9tszJUtkZFo0OMMTDK6RHh0TZMNItXfLQQ29cnaS Vih6UucF9grRNTUW0e9j3o/Ut8VHxu7/Bc7CGBGHjDK+jx7UZoiCygbNCyAP+wR0xRgV g8+puZ+gX7bdg+XeJ2UJXJQxLurvKQ16AzuHYrcbJzMR6b6T730EIKgUHtvz7DEbDILl 44ow== X-Gm-Message-State: AOAM5335VdDBCvARg9l3AJ1WMpdafVky6XfbbD5Ia9dKWVXeTNPUkiJA AVJIKOXs8+8G7ZVmN6M9tVVkc9RkCK+ODw== X-Google-Smtp-Source: ABdhPJyZ1Nnz/560XdRNP2Pf8ddKP+1o/pFsayrWvqYShUKVUqhkWz/6jagnFJoOMjfcB4zjNMNLcA== X-Received: by 2002:a1c:7f8b:: with SMTP id a133mr16309866wmd.155.1600432491428; Fri, 18 Sep 2020 05:34:51 -0700 (PDT) Received: from ?IPv6:2001:8a0:f905:5600:eefd:c63:53e0:3e8a? ([2001:8a0:f905:5600:eefd:c63:53e0:3e8a]) by smtp.gmail.com with ESMTPSA id x10sm5002718wmi.37.2020.09.18.05.34.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Sep 2020 05:34:50 -0700 (PDT) Subject: Re: [PATCH 1/2] Split gdb.multi/multi-target.exp into separate testcases To: Simon Marchi , gdb-patches@sourceware.org References: <20200917180038.29226-1-pedro@palves.net> <20200917180038.29226-2-pedro@palves.net> From: Pedro Alves Message-ID: <443e031f-68bc-a4cb-61ae-e63a6c6c1638@palves.net> Date: Fri, 18 Sep 2020 13:34:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Sep 2020 12:34:54 -0000 On 9/17/20 8:16 PM, Simon Marchi wrote: > On 2020-09-17 2:00 p.m., Pedro Alves wrote: >> gdb.multi/multi-target.exp sets up a debug environment with multiple >> gdbservers, multiple native processes, and multiple cores, which has >> proved useful for exercising a number of multi-target scenarios. >> >> But, as we add more tests to gdb.base/multi-target.exp, it is growing >> a bit too large (making a bit cumbersome to debug) and too slow to run >> (if you have glibc debug info). >> >> This commit thus splits the multi-target.exp into several testcases, >> one per use case. The common setup code is moved to a new >> multi-target.exp.tcl file that is included by all the resulting >> multi-target testcases. > > Nice, that makes the test cases much more readable too. I agree. >> + # We're use inferiors 1 and 2. Make sure they're really connected > > I just spotted this typo: "use" -> "using". I think I originally meant to say "We'll use". I fixed it to use that.