From: Michael Snyder <msnyder@redhat.com>
To: Andrew STUBBS <andrew.stubbs@st.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] allow nested sourced commands
Date: Wed, 05 Apr 2006 18:48:00 -0000 [thread overview]
Message-ID: <443410E1.50206@redhat.com> (raw)
In-Reply-To: <443395C0.6040709@st.com>
Andrew STUBBS wrote:
> Michael Snyder wrote:
>
>> Well, it has the virtue of simplicity!
>> At first glance, it seems conceptually valid.
>>
>> I think you need a clean-up, though. What if it errors?
>
> Look again, more closely :) arg_cleanup IS a clean-up.
Ah. So it is. ;-)
> Does that mean it is OK?
Hmmm, well, I'm not too familiar with that code, but it looks OK
programatically. Certainly should be commented better, though,
esp. since a struct called "user_args" now contains something
that's not a user arg.
Can you add a test in the testsuite?
next prev parent reply other threads:[~2006-04-05 18:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-30 14:29 command_line_input() not re-entrant Andrew STUBBS
2006-04-04 10:27 ` [PATCH] allow nested sourced commands Andrew STUBBS
2006-04-04 10:34 ` Andrew STUBBS
2006-04-04 19:58 ` Michael Snyder
2006-04-05 10:05 ` Andrew STUBBS
2006-04-05 18:48 ` Michael Snyder [this message]
2006-04-06 9:49 ` Andrew STUBBS
2006-04-06 13:40 ` Daniel Jacobowitz
2006-04-07 11:17 ` Andrew STUBBS
2006-04-07 13:18 ` Daniel Jacobowitz
2006-04-07 13:33 ` Andrew STUBBS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443410E1.50206@redhat.com \
--to=msnyder@redhat.com \
--cc=andrew.stubbs@st.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox