From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-43528-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2735 invoked by alias); 5 Apr 2006 18:48:14 -0000
Received: (qmail 2724 invoked by uid 22791); 5 Apr 2006 18:48:13 -0000
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Apr 2006 18:48:12 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) 	by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k35Im9ub001677; 	Wed, 5 Apr 2006 14:48:09 -0400
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) 	by int-mx1.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id k35Im3SJ015850; 	Wed, 5 Apr 2006 14:48:04 -0400
Received: from [172.16.24.50] (bluegiant.sfbay.redhat.com [172.16.24.50]) 	by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id k35Im2Tq021211; 	Wed, 5 Apr 2006 14:48:02 -0400
Message-ID: <443410E1.50206@redhat.com>
Date: Wed, 05 Apr 2006 18:48:00 -0000
From: Michael Snyder <msnyder@redhat.com>
User-Agent: Mozilla Thunderbird 1.0.7-1.4.1 (X11/20050929)
MIME-Version: 1.0
To: Andrew STUBBS <andrew.stubbs@st.com>
CC: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] allow nested sourced commands
References: <442BD6F1.8070804@st.com> <44324959.4@st.com> <44324B1E.3070409@st.com> <4432CFC1.4090308@redhat.com> <443395C0.6040709@st.com>
In-Reply-To: <443395C0.6040709@st.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-04/txt/msg00057.txt.bz2

Andrew STUBBS wrote:
> Michael Snyder wrote:
> 
>> Well, it has the virtue of simplicity!
>> At first glance, it seems conceptually valid.
>>
>> I think you need a clean-up, though.  What if it errors?
> 
> Look again, more closely :) arg_cleanup IS a clean-up.

Ah.  So it is.  ;-)

> Does that mean it is OK?

Hmmm, well, I'm not too familiar with that code, but it looks OK
programatically.  Certainly should be commented better, though,
esp. since a struct called "user_args" now contains something
that's not a user arg.

Can you add a test in the testsuite?