Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Andrew STUBBS <andrew.stubbs@st.com>
Cc: Michael Snyder <msnyder@redhat.com>,
		GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] allow nested sourced commands
Date: Thu, 06 Apr 2006 13:40:00 -0000	[thread overview]
Message-ID: <20060406134012.GA25478@nevyn.them.org> (raw)
In-Reply-To: <4434E361.40501@st.com>

On Thu, Apr 06, 2006 at 10:46:09AM +0100, Andrew STUBBS wrote:
> /* It is necessary to store a malloced copy of the command line to
> ensure that the arguments are not overwritten before they are used.  */

Sounds good to me.

> >Can you add a test in the testsuite?
> 
> Yes, I have the test case I posted before. Where would be the correct 
> place to add the test? Just add a new file under gdb.base?

Yes, please.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-04-06 13:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-30 14:29 command_line_input() not re-entrant Andrew STUBBS
2006-04-04 10:27 ` [PATCH] allow nested sourced commands Andrew STUBBS
2006-04-04 10:34   ` Andrew STUBBS
2006-04-04 19:58     ` Michael Snyder
2006-04-05 10:05       ` Andrew STUBBS
2006-04-05 18:48         ` Michael Snyder
2006-04-06  9:49           ` Andrew STUBBS
2006-04-06 13:40             ` Daniel Jacobowitz [this message]
2006-04-07 11:17               ` Andrew STUBBS
2006-04-07 13:18                 ` Daniel Jacobowitz
2006-04-07 13:33                   ` Andrew STUBBS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060406134012.GA25478@nevyn.them.org \
    --to=drow@false.org \
    --cc=andrew.stubbs@st.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox