From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5740 invoked by alias); 6 Apr 2006 13:40:19 -0000 Received: (qmail 5731 invoked by uid 22791); 6 Apr 2006 13:40:19 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 06 Apr 2006 13:40:18 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FRUia-0006e4-60; Thu, 06 Apr 2006 09:40:12 -0400 Date: Thu, 06 Apr 2006 13:40:00 -0000 From: Daniel Jacobowitz To: Andrew STUBBS Cc: Michael Snyder , GDB Patches Subject: Re: [PATCH] allow nested sourced commands Message-ID: <20060406134012.GA25478@nevyn.them.org> Mail-Followup-To: Andrew STUBBS , Michael Snyder , GDB Patches References: <442BD6F1.8070804@st.com> <44324959.4@st.com> <44324B1E.3070409@st.com> <4432CFC1.4090308@redhat.com> <443395C0.6040709@st.com> <443410E1.50206@redhat.com> <4434E361.40501@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4434E361.40501@st.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00071.txt.bz2 On Thu, Apr 06, 2006 at 10:46:09AM +0100, Andrew STUBBS wrote: > /* It is necessary to store a malloced copy of the command line to > ensure that the arguments are not overwritten before they are used. */ Sounds good to me. > >Can you add a test in the testsuite? > > Yes, I have the test case I posted before. Where would be the correct > place to add the test? Just add a new file under gdb.base? Yes, please. -- Daniel Jacobowitz CodeSourcery