Re: --disable-gdbmi build broken

[Tom de Vries <tdevries@suse.de>]

On 10-05-19 18:21, Simon Marchi wrote:
> On 2019-05-10 6:41 a.m., Tom de Vries wrote:
>> this change breaks the --disable-gdbmi build:
>> ...
>> ld: breakpoint.o: in function `print_one_breakpoint(breakpoint*,
>> bp_location**, int)':
>> src/gdb/breakpoint.c:6365: undefined reference to
>> `mi_multi_location_breakpoint_output_fixed(ui_out*)'
>> collect2: error: ld returned 1 exit status
>> make[1]: *** [Makefile:1893: gdb] Fout 1
> 
> Thanks for the report, I will look into fixing this.
> 
> Just wondering, do you actually use that configure option or find it useful?
> How did you stumble on this? Last year, Tom Tromey suggested to remove it, but
> we ended up keeping it just in case somebody actually used it, but there wasn't
> convincing evidence that it was actually used:
> 
>   https://sourceware.org/ml/gdb-patches/2018-07/msg00507.html
> 
> So if you actually use that option, it would give us a data point and a reason
> for us to keep it.

I did a bisect today for PR24545 - "Symbol loading performance
regression with cc1" (
https://sourceware.org/bugzilla/show_bug.cgi?id=24545 ), and I wanted a
minimal build time for a fast bisect, so I went to look what
gdb/configure listed as --disable-something options, which is how I
noticed this.

I don't know whether --disable-gdbmi actually makes the build much
shorter, I just used it because it was advertised.

Thanks,
- Tom