From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50370 invoked by alias); 10 May 2019 17:01:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50357 invoked by uid 89); 10 May 2019 17:01:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1422, 201807, 2018-07, wondering X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 May 2019 17:01:14 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8E762AD57; Fri, 10 May 2019 17:01:12 +0000 (UTC) Subject: Re: --disable-gdbmi build broken To: Simon Marchi , Eli Zaretskii Cc: "gdb-patches@sourceware.org" References: <20190118195659.23335-1-simon.marchi@ericsson.com> <83y37hbpwj.fsf@gnu.org> <44a5cfcc-d98e-fd14-ff47-755e218d76d0@ericsson.com> <5c79a173-d2eb-3e84-5d73-d52b0ec5fe17@simark.ca> <3e19640c-f4c8-8381-c77f-a636a97510d7@simark.ca> From: Tom de Vries Message-ID: <4418b362-9ae5-6631-948c-3a6f0ebf4668@suse.de> Date: Fri, 10 May 2019 17:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <3e19640c-f4c8-8381-c77f-a636a97510d7@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00256.txt.bz2 On 10-05-19 18:21, Simon Marchi wrote: > On 2019-05-10 6:41 a.m., Tom de Vries wrote: >> this change breaks the --disable-gdbmi build: >> ... >> ld: breakpoint.o: in function `print_one_breakpoint(breakpoint*, >> bp_location**, int)': >> src/gdb/breakpoint.c:6365: undefined reference to >> `mi_multi_location_breakpoint_output_fixed(ui_out*)' >> collect2: error: ld returned 1 exit status >> make[1]: *** [Makefile:1893: gdb] Fout 1 > > Thanks for the report, I will look into fixing this. > > Just wondering, do you actually use that configure option or find it useful? > How did you stumble on this? Last year, Tom Tromey suggested to remove it, but > we ended up keeping it just in case somebody actually used it, but there wasn't > convincing evidence that it was actually used: > > https://sourceware.org/ml/gdb-patches/2018-07/msg00507.html > > So if you actually use that option, it would give us a data point and a reason > for us to keep it. I did a bisect today for PR24545 - "Symbol loading performance regression with cc1" ( https://sourceware.org/bugzilla/show_bug.cgi?id=24545 ), and I wanted a minimal build time for a fast bisect, so I went to look what gdb/configure listed as --disable-something options, which is how I noticed this. I don't know whether --disable-gdbmi actually makes the build much shorter, I just used it because it was advertised. Thanks, - Tom