Re: [PATCH v2] Fix MI output for multi-location breakpoints

[Simon Marchi <simark@simark.ca>]

On 2019-01-21 12:09 p.m., Simon Marchi wrote:
> On 2019-01-18 4:46 p.m., Eli Zaretskii wrote:
>>> From: Simon Marchi <simon.marchi@ericsson.com>
>>> CC: Simon Marchi <simon.marchi@ericsson.com>
>>> Date: Fri, 18 Jan 2019 19:57:11 +0000
>>>
>>> +The following commands can be used to selectively enable behaviors from a
>>> +newer MI version.  They can be useful if you want to take advantage of feature
>>> +or bug fix only available in a more recent MI version than what you are using,
>>> +but can't yet migrate to that version for some reason.
>>> +
>>> +@table @code
>>> +
>>> +@item -fix-multi-location-breakpoint-output
>>> +Use the output for multi-location breakpoints which was introduced by MI 3.
>>> +This has no effect when using MI version 3 or later.
>>
>> I needed to read this text and the one in NEWS several times before I
>> figured out what is meant here.  How about this alternative instead:
>>
>>    If your front end cannot yet migrate to a more recent version of the
>>    MI protocol, you can nevertheless selectively enable specific features
>>    available in those recent MI versions, using the following commands:
>>
>>    @table @code
>>
>>    @item -fix-multi-location-breakpoint-output
>>    Use the output for multi-location breakpoints which was introduced by
>>    MI 3, even when using MI versions 2 or 1.  This command has no
>>    effect when using MI version 3 or later.
>>
>>    @end @table
> 
> Thanks, I adopted this wording.
> 
>> Otherwise, the documentation parts are OK.
> 
> Thanks for the reviews.
> 
> I am still open to comments about the code parts.  In any case, the patch will
> remain up for review at least until the GDB 8.3 branch is created.
> 
> Simon
> 
> 

This is now pushed.

Simon