Re: [PATCH v6 0/4] [gdb/tui] Fix crash with debuginfod query

[Tom de Vries <tdevries@suse.de>]

On 5/1/26 4:26 PM, Andrew Burgess wrote:
> Andrew Burgess <aburgess@redhat.com> writes:
> 
>> Tom de Vries <tdevries@suse.de> writes:
>>
>>> This patch series fixes two PRs, PR31449 and PR33794.
>>>
>>> An initial patch for PR31449 was submitted here [1].  A review comment
>>> reported a problem when using C-x C-a to enable TUI instead of "tui enable",
>>> not fixed by the patch.  This was filed as PR33794.
>>>
>>> The initial patch fixes PR31449 by calling a function that will force the
>>> debuginfod query to happen before enabling the TUI.
>>
>> Hi Tom,
>>
>> Just FYI, I'm not forgotten this patch.  I'm in the process of reviewing
>> it, and will have some feedback next week.
> 
> I finished looking through this series, and I couldn't shake the feeling
> that it should be possible to allow the prompt to be displayed correctly
> during the switch to TUI mode.
> 
> Fixing the 'tui enable' case is reasonably straight forward, but getting
> 'C-x C-a' to work correctly was a little harder, but I think I managed
> it in the end.
> 
> I've posted these patches as my take on this problem:
> 
>    https://inbox.sourceware.org/gdb-patches/cover.1777645161.git.aburgess@redhat.com
> 
> It would be great to hear what you think.
> 

Hi Andrew,

thanks for identifying that additional problem with 'C-x C-a' during a 
secondary prompt (patch #3).  The fix you came up with looks reasonably 
simple, and a low-risk backport to gdb-17-branch.

Patch #5 is not as trivial as the solution I proposed in this series, 
but I still think it's trivial enough to backport.

I do wonder whether patch #6 is backportable to gdb-17-branch, that 
looks a bit risky to me.

Unfortunately this is all the feedback I can provide, I'm on vacation 
for a week starting now.

Thanks,
- Tom

> Thanks,
> Andrew
>