From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ynF/MRjW9GlbTAkAWB0awg (envelope-from ) for ; Fri, 01 May 2026 12:34:32 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=wwskamdN; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hfJziV8R; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=wwskamdN; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hfJziV8R; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B75011E0BA; Fri, 01 May 2026 12:34:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 933841E067 for ; Fri, 01 May 2026 12:34:31 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 29EED44115D8 for ; Fri, 1 May 2026 16:34:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 29EED44115D8 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=wwskamdN; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hfJziV8R; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=wwskamdN; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hfJziV8R Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 564594BB8F4F for ; Fri, 1 May 2026 16:34:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 564594BB8F4F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 564594BB8F4F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777653246; cv=none; b=dYUWNowVR188sXHFiErrCi2/4PHsFiFSfxLz7GmEo2kwfHPK5OOcPLmd5NkUH/GR8hNnSOJEq80/M1Mgu0MEKqCVIBntAx30lNGk5g5OefKxw4naO4F6dz4a/scFOwM0HeO1Ybqe2o5LbYSe+mdXC6GqBsNy+HuEINQpSelQa+4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777653246; c=relaxed/simple; bh=NbCHmwF8qvDXFdEK6b5HF/+7uSjrK3Ug7FRgh1WPOmU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=JcDy2k2jjDWnuqO+HRg6AHiIFkPo9ZUaTw5rQGGEzSTFUHsD00AlsNOAAauu+lqQSV1f+YQM2jmD06xzENdgJZfNOPa83ynhMPuMxrl+GYTuWcUCbsLwhPcOriHnFMC7c0srdhixgigR7pqJgO5OXoLqNpbIVTOZ10AVxrkCmtA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 564594BB8F4F Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3DACB5BD3B; Fri, 1 May 2026 16:34:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777653245; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e3K4acJlWhxk77xjOoswL6VFzbKsiBneSjpBGILLKyw=; b=wwskamdNrptouFYVl4x3dodMK8qAfAYl966qQCKkJ2TxhHvPay3oiJN5mFuwm5shZQqRXR BH0E3eYEHqUNbkKwRRuZH5IcEbSCT2aLmmAX/MONGV/PGejekWpBQ1A3jhDV+U8Kkok8nq bW+mCw72xg6x8fJh1dAiin0WCn3drZk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777653245; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e3K4acJlWhxk77xjOoswL6VFzbKsiBneSjpBGILLKyw=; b=hfJziV8RqILdJ3XCqVXdLcXwxHr9l9305hVeoiwFr3ViyhP9QvCEf5xRy4tg6/l8oJ01jz OPBZsSq9dW6QmIBQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777653245; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e3K4acJlWhxk77xjOoswL6VFzbKsiBneSjpBGILLKyw=; b=wwskamdNrptouFYVl4x3dodMK8qAfAYl966qQCKkJ2TxhHvPay3oiJN5mFuwm5shZQqRXR BH0E3eYEHqUNbkKwRRuZH5IcEbSCT2aLmmAX/MONGV/PGejekWpBQ1A3jhDV+U8Kkok8nq bW+mCw72xg6x8fJh1dAiin0WCn3drZk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777653245; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e3K4acJlWhxk77xjOoswL6VFzbKsiBneSjpBGILLKyw=; b=hfJziV8RqILdJ3XCqVXdLcXwxHr9l9305hVeoiwFr3ViyhP9QvCEf5xRy4tg6/l8oJ01jz OPBZsSq9dW6QmIBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 295B7593B1; Fri, 1 May 2026 16:34:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1oDRCP3V9GmQQQAAD6G6ig (envelope-from ); Fri, 01 May 2026 16:34:05 +0000 Message-ID: <4300deb1-765a-48fe-9d3f-69122748547d@suse.de> Date: Fri, 1 May 2026 18:34:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 0/4] [gdb/tui] Fix crash with debuginfod query To: Andrew Burgess , gdb-patches@sourceware.org References: <20260417075719.852558-1-tdevries@suse.de> <87tssz14tz.fsf@redhat.com> <875x57fbof.fsf@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <875x57fbof.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, sourceware.org:url, suse.de:mid, suse.de:email] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/1/26 4:26 PM, Andrew Burgess wrote: > Andrew Burgess writes: > >> Tom de Vries writes: >> >>> This patch series fixes two PRs, PR31449 and PR33794. >>> >>> An initial patch for PR31449 was submitted here [1]. A review comment >>> reported a problem when using C-x C-a to enable TUI instead of "tui enable", >>> not fixed by the patch. This was filed as PR33794. >>> >>> The initial patch fixes PR31449 by calling a function that will force the >>> debuginfod query to happen before enabling the TUI. >> >> Hi Tom, >> >> Just FYI, I'm not forgotten this patch. I'm in the process of reviewing >> it, and will have some feedback next week. > > I finished looking through this series, and I couldn't shake the feeling > that it should be possible to allow the prompt to be displayed correctly > during the switch to TUI mode. > > Fixing the 'tui enable' case is reasonably straight forward, but getting > 'C-x C-a' to work correctly was a little harder, but I think I managed > it in the end. > > I've posted these patches as my take on this problem: > > https://inbox.sourceware.org/gdb-patches/cover.1777645161.git.aburgess@redhat.com > > It would be great to hear what you think. > Hi Andrew, thanks for identifying that additional problem with 'C-x C-a' during a secondary prompt (patch #3). The fix you came up with looks reasonably simple, and a low-risk backport to gdb-17-branch. Patch #5 is not as trivial as the solution I proposed in this series, but I still think it's trivial enough to backport. I do wonder whether patch #6 is backportable to gdb-17-branch, that looks a bit risky to me. Unfortunately this is all the feedback I can provide, I'm on vacation for a week starting now. Thanks, - Tom > Thanks, > Andrew >