From: Andrew Burgess <aburgess@redhat.com>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH v6 0/4] [gdb/tui] Fix crash with debuginfod query
Date: Fri, 01 May 2026 15:26:40 +0100 [thread overview]
Message-ID: <875x57fbof.fsf@redhat.com> (raw)
In-Reply-To: <87tssz14tz.fsf@redhat.com>
Andrew Burgess <aburgess@redhat.com> writes:
> Tom de Vries <tdevries@suse.de> writes:
>
>> This patch series fixes two PRs, PR31449 and PR33794.
>>
>> An initial patch for PR31449 was submitted here [1]. A review comment
>> reported a problem when using C-x C-a to enable TUI instead of "tui enable",
>> not fixed by the patch. This was filed as PR33794.
>>
>> The initial patch fixes PR31449 by calling a function that will force the
>> debuginfod query to happen before enabling the TUI.
>
> Hi Tom,
>
> Just FYI, I'm not forgotten this patch. I'm in the process of reviewing
> it, and will have some feedback next week.
I finished looking through this series, and I couldn't shake the feeling
that it should be possible to allow the prompt to be displayed correctly
during the switch to TUI mode.
Fixing the 'tui enable' case is reasonably straight forward, but getting
'C-x C-a' to work correctly was a little harder, but I think I managed
it in the end.
I've posted these patches as my take on this problem:
https://inbox.sourceware.org/gdb-patches/cover.1777645161.git.aburgess@redhat.com
It would be great to hear what you think.
Thanks,
Andrew
next prev parent reply other threads:[~2026-05-01 14:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 7:57 Tom de Vries
2026-04-17 7:57 ` [PATCH v6 1/4] [gdb/tui] Fix crash with debuginfod query (tui enable) Tom de Vries
2026-04-17 7:57 ` [PATCH v6 2/4] [gdb] Add debuginfod_enabled_ask_p Tom de Vries
2026-04-17 7:57 ` [PATCH v6 3/4] [gdb] Add defaulted_query_auto_answers_p Tom de Vries
2026-04-17 7:57 ` [PATCH v6 4/4] [gdb/tui] Fix crash with debuginfod query (C-x C-a) Tom de Vries
2026-04-25 14:40 ` [PATCH v6 0/4] [gdb/tui] Fix crash with debuginfod query Andrew Burgess
2026-05-01 14:26 ` Andrew Burgess [this message]
2026-05-01 16:34 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875x57fbof.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox