From: Nick Clifton <nickc@redhat.com>
To: Rodney Brown <rbrown@bravurasolutions.com.au>
Cc: gdb-patches@sources.redhat.com, binutils@sources.redhat.com
Subject: Re: Patch to bfd/aix5ppc-core.c for gdb-6.3 with gcc 4 on AIX5.1
Date: Tue, 02 Aug 2005 10:59:00 -0000 [thread overview]
Message-ID: <42EF5358.20408@redhat.com> (raw)
In-Reply-To: <4F3B985B8E683C45B8C5F76B7AAB5AE5215F70@EXCHANGE.bravurasolutions.local>
Hi Rodney,
> powerpc-ibm-aix5.1.0.0 gcc version 4.0.1
> ../../gdb-6.3/bfd/aix5ppc-core.c: In function 'xcoff64_core_p':
> ../../gdb-6.3/bfd/aix5ppc-core.c:120: error: invalid lvalue in
> assignment
I am unable to reproduce this failure :-(
> 2005-07-12 Rodney Brown <rbrown@bravurasolutions.com.au>
>
> * aix5ppc-core.c (core_hdr): #define as LHS varient.
> (xcoff64_core_p): Constify return_value variable.
I am hesitant to apply a patch which does not appear to be needed.
> -#define core_hdr(abfd) ((struct core_dumpxx *)
> abfd->tdata.any)
> +#define core_hdr(abfd) (abfd->tdata.any) /* gcc 4
> support */
Is this necessary. You could just alter the use of core_hdr() in
xcoff64_core_p() and leave the macro alone.
Cheers
Nick
next prev parent reply other threads:[~2005-08-02 10:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-15 9:17 Rodney Brown
2005-08-02 10:59 ` Nick Clifton [this message]
2005-08-03 2:25 Rodney Brown
2005-08-08 12:28 ` Nick Clifton
2005-08-09 8:59 Rodney Brown
2005-08-09 16:37 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42EF5358.20408@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=rbrown@bravurasolutions.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox