From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19703 invoked by alias); 2 Aug 2005 10:59:35 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19686 invoked by uid 22791); 2 Aug 2005 10:59:31 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 02 Aug 2005 10:59:31 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j72AxUUv022773; Tue, 2 Aug 2005 06:59:30 -0400 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j72AxTV06115; Tue, 2 Aug 2005 06:59:29 -0400 Received: from [172.31.0.98] (vpn-68-3.surrey.redhat.com [10.32.68.3]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j72AxGRm024995; Tue, 2 Aug 2005 11:59:22 +0100 Message-ID: <42EF5358.20408@redhat.com> Date: Tue, 02 Aug 2005 10:59:00 -0000 From: Nick Clifton User-Agent: Thunderbird 1.0+ (X11/20050801) MIME-Version: 1.0 To: Rodney Brown CC: gdb-patches@sources.redhat.com, binutils@sources.redhat.com Subject: Re: Patch to bfd/aix5ppc-core.c for gdb-6.3 with gcc 4 on AIX5.1 References: <4F3B985B8E683C45B8C5F76B7AAB5AE5215F70@EXCHANGE.bravurasolutions.local> In-Reply-To: <4F3B985B8E683C45B8C5F76B7AAB5AE5215F70@EXCHANGE.bravurasolutions.local> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-08/txt/msg00042.txt.bz2 Hi Rodney, > powerpc-ibm-aix5.1.0.0 gcc version 4.0.1 > ../../gdb-6.3/bfd/aix5ppc-core.c: In function 'xcoff64_core_p': > ../../gdb-6.3/bfd/aix5ppc-core.c:120: error: invalid lvalue in > assignment I am unable to reproduce this failure :-( > 2005-07-12 Rodney Brown > > * aix5ppc-core.c (core_hdr): #define as LHS varient. > (xcoff64_core_p): Constify return_value variable. I am hesitant to apply a patch which does not appear to be needed. > -#define core_hdr(abfd) ((struct core_dumpxx *) > abfd->tdata.any) > +#define core_hdr(abfd) (abfd->tdata.any) /* gcc 4 > support */ Is this necessary. You could just alter the use of core_hdr() in xcoff64_core_p() and leave the macro alone. Cheers Nick