bug when stringify more then one tracepoint (one line patch)

bug when stringify more then one tracepoint (one line patch)

[josef ezra]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]


Hello

In this code, since "count" accumulates the length of tracepoints 
bytecode, adding it to "end" caused gaps of arbitrary data at the buffer.


2005-03-01  Josef Ezra <jezra@emc.com>
	* tracepoint.c (stringify_collection_list): Correcting position 		of 
next tracepoint to stringify at buffer.


[-- Attachment #2: tracepoints-bugfix.diff --]
[-- Type: text/plain, Size: 567 bytes --]

*** tracepoint.c	2005-03-01 12:04:21.000011000 -0500
--- tracepoint.c.orig	2005-03-01 11:54:47.000011000 -0500
*************** stringify_collection_list (struct collec
*** 1439,1445 ****
  	       (long) (list->list[i].end - list->list[i].start));
  
        count += strlen (end);
!       end += count;
      }
  
    for (i = 0; i < list->next_aexpr_elt; i++)
--- 1439,1445 ----
  	       (long) (list->list[i].end - list->list[i].start));
  
        count += strlen (end);
!       end = temp_buf + count;
      }
  
    for (i = 0; i < list->next_aexpr_elt; i++)

Re: bug when stringify more then one tracepoint (one line patch)

[Daniel Jacobowitz]

On Tue, Mar 01, 2005 at 03:06:56PM -0500, josef ezra wrote:
> 
> Hello
> 
> In this code, since "count" accumulates the length of tracepoints 
> bytecode, adding it to "end" caused gaps of arbitrary data at the buffer.
> 
> 
> 2005-03-01  Josef Ezra <jezra@emc.com>
> 	* tracepoint.c (stringify_collection_list): Correcting position  of next 
> tracepoint to stringify at buffer.

Hi Josef,

Thanks for the patch.  It looks correct to me; but could you describe
how to trigger this bug?

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: bug when stringify more then one tracepoint (one line patch)

[josef ezra]

Hello Daniel

Thank you for checking my report.

The bug happens when user creates more then one memrange collection items.

I have tried to add a test to gdb.trace/collection.exp (the current one 
collects one chunk of globals), but it keep complaining about “Current 
target does not support trace”.

To follow collection.exp example, the commands:

(gdb) file collections
(gdb) target remote host_running_collection:9999
(gdb) trace globals_test_func
(gdb) actions
 > collect globalc
 > collect globald
 > end
(gdb) tstart

Would send the target a string with arbitrary characters.

- Josef Ezra


Daniel Jacobowitz wrote:
> On Tue, Mar 01, 2005 at 03:06:56PM -0500, josef ezra wrote:
> 
>>Hello
>>
>>In this code, since "count" accumulates the length of tracepoints 
>>bytecode, adding it to "end" caused gaps of arbitrary data at the buffer.
>>
>>
>>2005-03-01  Josef Ezra <jezra@emc.com>
>>	* tracepoint.c (stringify_collection_list): Correcting position  of next 
>>tracepoint to stringify at buffer.
> 
> 
> Hi Josef,
> 
> Thanks for the patch.  It looks correct to me; but could you describe
> how to trigger this bug?
> 

Re: bug when stringify more then one tracepoint (one line patch)

[Daniel Jacobowitz]

On Mon, May 02, 2005 at 02:57:03PM -0400, josef ezra wrote:
> Hello Daniel
> 
> Thank you for checking my report.
> 
> The bug happens when user creates more then one memrange collection items.

I've checked in the patch.  I don't have a target I can test
tracepoints on, so I haven't tried to add a test to the testsuite.

Thanks!


-- 
Daniel Jacobowitz
CodeSourcery, LLC