From: Andrew Cagney <cagney@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit] Mark up add_cmd
Date: Tue, 15 Feb 2005 04:52:00 -0000 [thread overview]
Message-ID: <421156FB.70907@gnu.org> (raw)
In-Reply-To: <01c512e1$Blat.v2.4$149cf760@zahav.net.il>
Eli Zaretskii wrote:
>>Date: Mon, 14 Feb 2005 13:09:19 -0500
>>From: Andrew Cagney <cagney@gnu.org>
>>
>>another one down,
>
>
> Thanks, but please, PLEASE let us return to the normal review process!
It's taken us three months to get through files a-c, simple math tells
us that at that rate we'll finish sometime on '07. I don't think so.
> Sigh. I don't know anymore why should I bother reviewing patches when
> they are committed unconditionally, but here goes anyway...
As you identify problems, please mark them in the code using a comment
of the form:
/* FIXME: i18n: ...
They will then be fixed during later passes.
Andrew
next prev parent reply other threads:[~2005-02-15 1:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-14 21:45 Andrew Cagney
2005-02-15 2:04 ` Eli Zaretskii
2005-02-15 4:52 ` Andrew Cagney [this message]
2005-02-15 15:36 ` Eli Zaretskii
2005-02-15 15:51 ` Bob Rossi
2005-02-15 17:14 ` Baurzhan Ismagulov
2005-02-15 23:20 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=421156FB.70907@gnu.org \
--to=cagney@gnu.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox