From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-38082-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 10455 invoked by alias); 15 Feb 2005 01:58:44 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 9747 invoked from network); 15 Feb 2005 01:58:41 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 15 Feb 2005 01:58:41 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j1F1wePD000315
	for <gdb-patches@sources.redhat.com>; Mon, 14 Feb 2005 20:58:41 -0500
Received: from localhost.redhat.com (vpn50-115.rdu.redhat.com [172.16.50.115])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j1F1weO23737;
	Mon, 14 Feb 2005 20:58:40 -0500
Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP id 266617D79;
	Mon, 14 Feb 2005 20:57:17 -0500 (EST)
Message-ID: <421156FB.70907@gnu.org>
Date: Tue, 15 Feb 2005 04:52:00 -0000
From: Andrew Cagney <cagney@gnu.org>
User-Agent: Mozilla Thunderbird 0.8 (X11/20041020)
MIME-Version: 1.0
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit] Mark up add_cmd
References: <4210E94F.6010505@gnu.org> <01c512e1$Blat.v2.4$149cf760@zahav.net.il>
In-Reply-To: <01c512e1$Blat.v2.4$149cf760@zahav.net.il>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2005-02/txt/msg00139.txt.bz2

Eli Zaretskii wrote:
>>Date: Mon, 14 Feb 2005 13:09:19 -0500
>>From: Andrew Cagney <cagney@gnu.org>
>>
>>another one down,
> 
> 
> Thanks, but please, PLEASE let us return to the normal review process!

It's taken us three months to get through files a-c, simple math tells 
us that at that rate we'll finish sometime on '07.  I don't think so.

> Sigh.  I don't know anymore why should I bother reviewing patches when
> they are committed unconditionally, but here goes anyway...

As you identify problems, please mark them in the code using a comment 
of the form:

	/* FIXME: i18n: ...

They will then be fixed during later passes.

Andrew