Re: [commit/sim] Add common/common.m4; Was: [commit/sim] switch autoconf 2.59

[Andrew Cagney <cagney@gnu.org>]

Hans-Peter Nilsson wrote:
> On Wed, 12 Jan 2005, Andrew Cagney wrote:
> 
> 
>>I've also committed the attached.  It gets around the SIM_AC_COMMON
>>problem by inlining the macro's contents.
>>
>>Your turn :-)
> 
> 
> With current sources (after adding common.m4), CY_GNU_GETTEXT is
> not defined before use (checkout, configury and build as
> before):
> ...
> configure: configuring in frv
> ...
> /n/asic/slask/hp/fixsimbreakage/src/sim/frv/configure: CY_GNU_GETTEXT: command not found
> ...
> (further problems ignored.)
> 
> The bug seen above can be fixed by sincluding aclocal.m4 before
> common.m4, putting the definition before the call.  (After that
> I then see some disturbing warnings when compiling
> sim/frv/sem.c, but those aren't any fault of the configury at
> least, so that's to be considered a success.)
> 
> I'm not sure why you didn't just sinclude common.m4 from
> aclocal.m4 and why you didn't remove SIM_AC_COMMON from
> aclocal.m4.  Therefore I don't know how you want the above and
> the worry below actually fixed and so I'll pass back the "your
> turn". ;-)

(I don't like nested includes, and aclocal.m4 should just contain macro 
definitions :-)

Have a look at common/configure.ac.  It's still calling SIM_AC_COMMON 
with a parameter, hence my reason for keeping the SIM_AC_COMMON macro 
(well for at least the moment).

To do like you suggest would mean adding AC_CONFIG_HEADER to 
*/configure.ac (possibly not a bad thing - common/ is probably still 
broken).

> The biggest problem is that I don't understand why breaking out
> SIM_AC_COMMON to common.m4 should help at all, but it does.

Yea, weird :-)

I'll flip the sinclude order.

Andrew