From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28759 invoked by alias); 13 Jan 2005 21:50:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28626 invoked from network); 13 Jan 2005 21:50:01 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 13 Jan 2005 21:50:01 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j0DLo0U7023889 for ; Thu, 13 Jan 2005 16:50:01 -0500 Received: from localhost.redhat.com (vpn50-43.rdu.redhat.com [172.16.50.43]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j0DLnxr08436; Thu, 13 Jan 2005 16:50:00 -0500 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 0829F7D79; Thu, 13 Jan 2005 16:48:18 -0500 (EST) Message-ID: <41E6ECA1.2040209@gnu.org> Date: Thu, 13 Jan 2005 21:50:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: Hans-Peter Nilsson Cc: gdb-patches@sources.redhat.com Subject: Re: [commit/sim] Add common/common.m4; Was: [commit/sim] switch autoconf 2.59 References: <41DF55E5.7010307@gnu.org> <41E43F98.1010601@gnu.org> <41E47C74.3050607@gnu.org> <41E5501A.3000907@gnu.org> <41E55AB7.1060802@gnu.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-01/txt/msg00108.txt.bz2 Hans-Peter Nilsson wrote: > On Wed, 12 Jan 2005, Andrew Cagney wrote: > > >>I've also committed the attached. It gets around the SIM_AC_COMMON >>problem by inlining the macro's contents. >> >>Your turn :-) > > > With current sources (after adding common.m4), CY_GNU_GETTEXT is > not defined before use (checkout, configury and build as > before): > ... > configure: configuring in frv > ... > /n/asic/slask/hp/fixsimbreakage/src/sim/frv/configure: CY_GNU_GETTEXT: command not found > ... > (further problems ignored.) > > The bug seen above can be fixed by sincluding aclocal.m4 before > common.m4, putting the definition before the call. (After that > I then see some disturbing warnings when compiling > sim/frv/sem.c, but those aren't any fault of the configury at > least, so that's to be considered a success.) > > I'm not sure why you didn't just sinclude common.m4 from > aclocal.m4 and why you didn't remove SIM_AC_COMMON from > aclocal.m4. Therefore I don't know how you want the above and > the worry below actually fixed and so I'll pass back the "your > turn". ;-) (I don't like nested includes, and aclocal.m4 should just contain macro definitions :-) Have a look at common/configure.ac. It's still calling SIM_AC_COMMON with a parameter, hence my reason for keeping the SIM_AC_COMMON macro (well for at least the moment). To do like you suggest would mean adding AC_CONFIG_HEADER to */configure.ac (possibly not a bad thing - common/ is probably still broken). > The biggest problem is that I don't understand why breaking out > SIM_AC_COMMON to common.m4 should help at all, but it does. Yea, weird :-) I'll flip the sinclude order. Andrew