Re: [commit/sim] Add common/common.m4; Was: [commit/sim] switch autoconf 2.59

[Hans-Peter Nilsson <hp@bitrange.com>]

On Wed, 12 Jan 2005, Andrew Cagney wrote:

> I've also committed the attached.  It gets around the SIM_AC_COMMON
> problem by inlining the macro's contents.
>
> Your turn :-)

With current sources (after adding common.m4), CY_GNU_GETTEXT is
not defined before use (checkout, configury and build as
before):
...
configure: configuring in frv
...
/n/asic/slask/hp/fixsimbreakage/src/sim/frv/configure: CY_GNU_GETTEXT: command not found
...
(further problems ignored.)

The bug seen above can be fixed by sincluding aclocal.m4 before
common.m4, putting the definition before the call.  (After that
I then see some disturbing warnings when compiling
sim/frv/sem.c, but those aren't any fault of the configury at
least, so that's to be considered a success.)

I'm not sure why you didn't just sinclude common.m4 from
aclocal.m4 and why you didn't remove SIM_AC_COMMON from
aclocal.m4.  Therefore I don't know how you want the above and
the worry below actually fixed and so I'll pass back the "your
turn". ;-)

The biggest problem is that I don't understand why breaking out
SIM_AC_COMMON to common.m4 should help at all, but it does.

Editing aclocal:SIM_AC_COMMON to look *exactly* like common.a4
(or indeed leaving it the same; the ifelse does the same) and
this diff to sim/frv/configure.ac (note order of sincludes
assumed fixed as per above):

--- configure.ac.fixed  Thu Jan 13 04:25:38 2005
+++ configure.ac        Thu Jan 13 04:33:45 2005
@@ -3,7 +3,7 @@ AC_PREREQ(2.59)dnl
 AC_INIT(Makefile.in)

 sinclude(../common/aclocal.m4)
-sinclude(../common/common.m4)
+SIM_AC_COMMON

 SIM_AC_OPTION_ENDIAN(BIG_ENDIAN)
 SIM_AC_OPTION_ALIGNMENT(STRICT_ALIGNMENT)

*should* do the same.  But it doesn't; it seems for example
AC_CANONICAL_SYSTEM and AC_PROG_CC aren't called (and from that
point configury derails causing declarations and macros wrong
and missing at compile time).  Weird.  A prominent note that the
contents of common.m4 must not be wrapped and called as a macro
seems in order.  The comment at the top of common.m4
"autoconf.info says this should be called right after AC_INIT"
doesn't tell the important part of the story.

brgds, H-P