From: Andrew Cagney <cagney@gnu.org>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/mips] Remove mips16 code that seems redundant
Date: Mon, 11 Oct 2004 01:59:00 -0000 [thread overview]
Message-ID: <4169E8AE.6070009@gnu.org> (raw)
In-Reply-To: <20041011013934.GX26446@gnat.com>
>>This?
>
>
> Ah, bummer, keep forgetting the patch (that's because my mind is
> already further ahead - sorry).
>
> Here is the patch:
Ah, that, I need to do an update. Still ok.
Andrew
.
> Index: mips-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/mips-tdep.c,v
> retrieving revision 1.328
> diff -u -p -r1.328 mips-tdep.c
> --- mips-tdep.c 11 Oct 2004 01:00:57 -0000 1.328
> +++ mips-tdep.c 11 Oct 2004 01:10:54 -0000
> @@ -2409,36 +2409,6 @@ mips16_heuristic_proc_desc (CORE_ADDR st
> this_cache->saved_regs[NUM_REGS + mips_regnum (current_gdbarch)->pc]
> = this_cache->saved_regs[NUM_REGS + RA_REGNUM];
> }
> -
> - /* The MIPS16 entry instruction saves $s0 and $s1 in the reverse
> - order of that normally used by gcc. Therefore, we have to fetch
> - the first instruction of the function, and if it's an entry
> - instruction that saves $s0 or $s1, correct their saved addresses. */
> - /* FIXME: brobecker/2004-10-10: This code was moved here from
> - mips_insn16_frame_cache(), but can be merged with the block above
> - handling entry_inst. Will be done in a separate pass, to make changes
> - more atomic. Actually, this code seems completely redundant! */
next prev parent reply other threads:[~2004-10-11 1:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-11 1:16 Joel Brobecker
2004-10-11 1:35 ` Andrew Cagney
2004-10-11 1:39 ` Joel Brobecker
2004-10-11 1:59 ` Andrew Cagney [this message]
2004-10-11 2:28 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4169E8AE.6070009@gnu.org \
--to=cagney@gnu.org \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox