From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12479 invoked by alias); 11 Oct 2004 01:59:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10956 invoked from network); 11 Oct 2004 01:58:46 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 11 Oct 2004 01:58:46 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i9B1wVp7002160 for ; Sun, 10 Oct 2004 21:58:36 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i9B1wQr29530; Sun, 10 Oct 2004 21:58:26 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 3ABBA28CD; Sun, 10 Oct 2004 21:58:06 -0400 (EDT) Message-ID: <4169E8AE.6070009@gnu.org> Date: Mon, 11 Oct 2004 01:59:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20041009 MIME-Version: 1.0 To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/mips] Remove mips16 code that seems redundant References: <20041011011652.GW26446@gnat.com> <4169E35C.2050007@gnu.org> <20041011013934.GX26446@gnat.com> In-Reply-To: <20041011013934.GX26446@gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-10/txt/msg00180.txt.bz2 >>This? > > > Ah, bummer, keep forgetting the patch (that's because my mind is > already further ahead - sorry). > > Here is the patch: Ah, that, I need to do an update. Still ok. Andrew . > Index: mips-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/mips-tdep.c,v > retrieving revision 1.328 > diff -u -p -r1.328 mips-tdep.c > --- mips-tdep.c 11 Oct 2004 01:00:57 -0000 1.328 > +++ mips-tdep.c 11 Oct 2004 01:10:54 -0000 > @@ -2409,36 +2409,6 @@ mips16_heuristic_proc_desc (CORE_ADDR st > this_cache->saved_regs[NUM_REGS + mips_regnum (current_gdbarch)->pc] > = this_cache->saved_regs[NUM_REGS + RA_REGNUM]; > } > - > - /* The MIPS16 entry instruction saves $s0 and $s1 in the reverse > - order of that normally used by gcc. Therefore, we have to fetch > - the first instruction of the function, and if it's an entry > - instruction that saves $s0 or $s1, correct their saved addresses. */ > - /* FIXME: brobecker/2004-10-10: This code was moved here from > - mips_insn16_frame_cache(), but can be merged with the block above > - handling entry_inst. Will be done in a separate pass, to make changes > - more atomic. Actually, this code seems completely redundant! */