From: Joel Brobecker <brobecker@gnat.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: [RFA/mips] Remove mips16 code that seems redundant
Date: Mon, 11 Oct 2004 01:16:00 -0000 [thread overview]
Message-ID: <20041011011652.GW26446@gnat.com> (raw)
Andrew,
The block quoted in this patch was moved from mips_insn16_frame_cache()
to there (mips16_heuristic_proc_desc), and I was contemplenting the idea
of merging it the block slightly above in the same function that handles
the case when the first instruction is an entry insn. But then, looking
a bit deeper, it really seems to me that everything done in that block
is already done above. No matter how hard I look, I can't see the catch.
Is there any?
If not, I suggest removing this code. Otherwise, I'll do the merge
I thought about.
2004-10-10 Joel Brobecker <brobecker@gnat.com>
* mips-tdep.c (mips16_heuristic_proc_desc): Remove redundant code.
What do you think?
Thanks,
--
Joel
next reply other threads:[~2004-10-11 1:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-11 1:16 Joel Brobecker [this message]
2004-10-11 1:35 ` Andrew Cagney
2004-10-11 1:39 ` Joel Brobecker
2004-10-11 1:59 ` Andrew Cagney
2004-10-11 2:28 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041011011652.GW26446@gnat.com \
--to=brobecker@gnat.com \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox