From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28481 invoked by alias); 11 Oct 2004 01:16:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28474 invoked from network); 11 Oct 2004 01:16:53 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sourceware.org with SMTP; 11 Oct 2004 01:16:53 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id BB2BB47D98; Sun, 10 Oct 2004 18:16:52 -0700 (PDT) Date: Mon, 11 Oct 2004 01:16:00 -0000 From: Joel Brobecker To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: [RFA/mips] Remove mips16 code that seems redundant Message-ID: <20041011011652.GW26446@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4i X-SW-Source: 2004-10/txt/msg00176.txt.bz2 Andrew, The block quoted in this patch was moved from mips_insn16_frame_cache() to there (mips16_heuristic_proc_desc), and I was contemplenting the idea of merging it the block slightly above in the same function that handles the case when the first instruction is an entry insn. But then, looking a bit deeper, it really seems to me that everything done in that block is already done above. No matter how hard I look, I can't see the catch. Is there any? If not, I suggest removing this code. Otherwise, I'll do the merge I thought about. 2004-10-10 Joel Brobecker * mips-tdep.c (mips16_heuristic_proc_desc): Remove redundant code. What do you think? Thanks, -- Joel