Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: Andrew Cagney <cagney@gnu.org>, gdb-patches@sources.redhat.com
Subject: Re: [rfa/threads] Eliminate lin-lwp.c
Date: Fri, 17 Sep 2004 22:07:00 -0000	[thread overview]
Message-ID: <414B600A.1070709@redhat.com> (raw)
In-Reply-To: <20040916212547.GB28956@nevyn.them.org>

Daniel Jacobowitz wrote:
> On Thu, Sep 16, 2004 at 05:11:27PM -0400, Andrew Cagney wrote:
> 
>>>I do not think that leaving these functions where they are will
>>>complicate the process of cleaning them up.  Could you explain
>>>why you see this as a problem?
>>
>>As with inf-child and inf-ptrace, an important objective here is to get 
>>all the inf-linux methods local to a file so that we can ensure that all 
>>accesses are strictly via the target vector.  Leaving them where they 
>>are defeats this, a little.
> 
> 
> So the reason you want them all in one file is so that you can make
> them all static, and ensure they aren't accessed "on the side".  Is
> that right?  That's a good technical reason for this patch, one which I
> didn't think of and you didn't explain.  I'm just trying to get you to
> share your wisdom with all us other maintainers.
> 
> With that explanation presented, I have no objection.  Let's make sure
> Michael agrees.

I'm fine with it.



  parent reply	other threads:[~2004-09-17 22:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-16 15:36 Andrew Cagney
2004-09-16 15:48 ` Daniel Jacobowitz
2004-09-16 16:05   ` Andrew Cagney
2004-09-16 16:22     ` Daniel Jacobowitz
2004-09-16 16:32       ` Andrew Cagney
2004-09-16 17:38         ` Daniel Jacobowitz
2004-09-16 20:12           ` Andrew Cagney
2004-09-16 20:29             ` Daniel Jacobowitz
2004-09-16 21:13               ` Andrew Cagney
2004-09-16 21:25                 ` Daniel Jacobowitz
2004-09-16 22:23                   ` Andrew Cagney
2004-09-17 22:07                   ` Michael Snyder [this message]
2004-09-27 19:58 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=414B600A.1070709@redhat.com \
    --to=msnyder@redhat.com \
    --cc=cagney@gnu.org \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox