Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/threads] Eliminate lin-lwp.c
Date: Thu, 16 Sep 2004 21:13:00 -0000	[thread overview]
Message-ID: <414A017F.8090803@gnu.org> (raw)
In-Reply-To: <20040916202905.GA26644@nevyn.them.org>

> I do not think that leaving these functions where they are will
> complicate the process of cleaning them up.  Could you explain
> why you see this as a problem?

As with inf-child and inf-ptrace, an important objective here is to get 
all the inf-linux methods local to a file so that we can ensure that all 
accesses are strictly via the target vector.  Leaving them where they 
are defeats this, a little.

>>linux-inf.c?  inf-linux.c is equally (if not more) consistent with the 
>>> new inf-ptrace.c and inf-child.c.
> 
> 
> inf-* are currently more or less target agnostic; just "unixy".

inf-child, the current root object is very un "unixy".

 > GDB
> convention says that native support for Linux - that's what this is -
> belongs in linux-nat.c.  If some of it is left in lin-lwp.c for
> historical reasons, that's a separate issue.

Here we're going to end up with:

	inf-i386-linux is-a inf-linux (is-a inf-ptrace?) is-a inf-child

Lets not be shy with the code base.  inf-linux.c, containing the 
inf-linux class, is going to be far more consistent in the long term. 
(the only alt I see is a name reversal of linux-inf, child-inf, 
ptrace-inf, ...).

What about I fix up i386 and then come back for the others?

Andrew



  reply	other threads:[~2004-09-16 21:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-16 15:36 Andrew Cagney
2004-09-16 15:48 ` Daniel Jacobowitz
2004-09-16 16:05   ` Andrew Cagney
2004-09-16 16:22     ` Daniel Jacobowitz
2004-09-16 16:32       ` Andrew Cagney
2004-09-16 17:38         ` Daniel Jacobowitz
2004-09-16 20:12           ` Andrew Cagney
2004-09-16 20:29             ` Daniel Jacobowitz
2004-09-16 21:13               ` Andrew Cagney [this message]
2004-09-16 21:25                 ` Daniel Jacobowitz
2004-09-16 22:23                   ` Andrew Cagney
2004-09-17 22:07                   ` Michael Snyder
2004-09-27 19:58 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=414A017F.8090803@gnu.org \
    --to=cagney@gnu.org \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox