From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13092 invoked by alias); 16 Sep 2004 21:13:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13084 invoked from network); 16 Sep 2004 21:13:56 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 16 Sep 2004 21:13:56 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i8GLDp0K032227 for ; Thu, 16 Sep 2004 17:13:51 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i8GLDer22650; Thu, 16 Sep 2004 17:13:40 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id B713828D2; Thu, 16 Sep 2004 17:11:27 -0400 (EDT) Message-ID: <414A017F.8090803@gnu.org> Date: Thu, 16 Sep 2004 21:13:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040831 MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa/threads] Eliminate lin-lwp.c References: <4149B268.3060506@gnu.org> <20040916154758.GA15671@nevyn.them.org> <4149B92F.9080106@gnu.org> <20040916162209.GA7695@nevyn.them.org> <4149BF93.6050805@gnu.org> <20040916173816.GB14498@nevyn.them.org> <4149F32F.6030807@gnu.org> <20040916202905.GA26644@nevyn.them.org> In-Reply-To: <20040916202905.GA26644@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00284.txt.bz2 > I do not think that leaving these functions where they are will > complicate the process of cleaning them up. Could you explain > why you see this as a problem? As with inf-child and inf-ptrace, an important objective here is to get all the inf-linux methods local to a file so that we can ensure that all accesses are strictly via the target vector. Leaving them where they are defeats this, a little. >>linux-inf.c? inf-linux.c is equally (if not more) consistent with the >>> new inf-ptrace.c and inf-child.c. > > > inf-* are currently more or less target agnostic; just "unixy". inf-child, the current root object is very un "unixy". > GDB > convention says that native support for Linux - that's what this is - > belongs in linux-nat.c. If some of it is left in lin-lwp.c for > historical reasons, that's a separate issue. Here we're going to end up with: inf-i386-linux is-a inf-linux (is-a inf-ptrace?) is-a inf-child Lets not be shy with the code base. inf-linux.c, containing the inf-linux class, is going to be far more consistent in the long term. (the only alt I see is a name reversal of linux-inf, child-inf, ptrace-inf, ...). What about I fix up i386 and then come back for the others? Andrew