From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13539 invoked by alias); 17 Sep 2004 22:07:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13360 invoked from network); 17 Sep 2004 22:07:10 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 17 Sep 2004 22:07:10 -0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i8HM79qs027882 for ; Fri, 17 Sep 2004 18:07:10 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i8HM78714802; Fri, 17 Sep 2004 18:07:08 -0400 Received: from redhat.com (dhcp-172-16-25-160.sfbay.redhat.com [172.16.25.160]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i8HM76V01121; Fri, 17 Sep 2004 15:07:06 -0700 Message-ID: <414B600A.1070709@redhat.com> Date: Fri, 17 Sep 2004 22:07:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; es-ES; rv:1.4.2) Gecko/20040301 MIME-Version: 1.0 To: Daniel Jacobowitz CC: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [rfa/threads] Eliminate lin-lwp.c References: <4149B268.3060506@gnu.org> <20040916154758.GA15671@nevyn.them.org> <4149B92F.9080106@gnu.org> <20040916162209.GA7695@nevyn.them.org> <4149BF93.6050805@gnu.org> <20040916173816.GB14498@nevyn.them.org> <4149F32F.6030807@gnu.org> <20040916202905.GA26644@nevyn.them.org> <414A017F.8090803@gnu.org> <20040916212547.GB28956@nevyn.them.org> In-Reply-To: <20040916212547.GB28956@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00289.txt.bz2 Daniel Jacobowitz wrote: > On Thu, Sep 16, 2004 at 05:11:27PM -0400, Andrew Cagney wrote: > >>>I do not think that leaving these functions where they are will >>>complicate the process of cleaning them up. Could you explain >>>why you see this as a problem? >> >>As with inf-child and inf-ptrace, an important objective here is to get >>all the inf-linux methods local to a file so that we can ensure that all >>accesses are strictly via the target vector. Leaving them where they >>are defeats this, a little. > > > So the reason you want them all in one file is so that you can make > them all static, and ensure they aren't accessed "on the side". Is > that right? That's a good technical reason for this patch, one which I > didn't think of and you didn't explain. I'm just trying to get you to > share your wisdom with all us other maintainers. > > With that explanation presented, I have no objection. Let's make sure > Michael agrees. I'm fine with it.