From: Michael Chastain <mec.gnu@mindspring.com>
To: manjo@austin.ibm.com, cagney@gnu.org, jimb@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: adapt gdb/testsuite/config/sim.exp to new gdb_file_cmd
Date: Thu, 09 Sep 2004 17:33:00 -0000 [thread overview]
Message-ID: <414093F9.nailER617FY73@mindspring.com> (raw)
In-Reply-To: <vt2y8jkuyz1.fsf@zenia.home>
Jim Blandy <jimb@redhat.com> wrote:
> Here's a caller of gdb_file_cmd that wasn't updated when the type of
> its return value was changed.
Yes. I didn't even look in config/*.exp when I changed the return type
of gdb_file_cmd and gdb_load. I thought there was one implementation of
gdb_load, but actually, there are nine implementations!
I've thought about this and I've decided to revert the return type
change. After that, I'll change gdb_file_cmd to set a global variable,
which gdb.gdb/*.exp will test.
So I'm declining this patch. I'll have the breakage fixed shortly,
and then add the new global.
Michael
> 2004-09-08 Jim Blandy <jimb@redhat.com>
>
> * config/sim.exp (gdb_load): Adapt to expect and return new return
> values from gdb_file_command.
prev parent reply other threads:[~2004-09-09 17:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-08 23:24 Jim Blandy
2004-09-09 17:33 ` Michael Chastain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=414093F9.nailER617FY73@mindspring.com \
--to=mec.gnu@mindspring.com \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
--cc=manjo@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox