From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11306 invoked by alias); 9 Sep 2004 17:33:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11299 invoked from network); 9 Sep 2004 17:33:45 -0000 Received: from unknown (HELO maynard.mail.mindspring.net) (207.69.200.243) by sourceware.org with SMTP; 9 Sep 2004 17:33:45 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by maynard.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1C5SnZ-0002hr-00; Thu, 09 Sep 2004 13:33:29 -0400 Received: from mindspring.com (localhost [127.0.0.1]) by berman.michael-chastain.com (Postfix) with SMTP id 41FFA4B102; Thu, 9 Sep 2004 13:33:46 -0400 (EDT) Date: Thu, 09 Sep 2004 17:33:00 -0000 From: Michael Chastain To: manjo@austin.ibm.com, cagney@gnu.org, jimb@redhat.com Subject: Re: RFA: adapt gdb/testsuite/config/sim.exp to new gdb_file_cmd Cc: gdb-patches@sources.redhat.com Message-ID: <414093F9.nailER617FY73@mindspring.com> References: In-Reply-To: User-Agent: nail 10.8 6/28/04 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00147.txt.bz2 Jim Blandy wrote: > Here's a caller of gdb_file_cmd that wasn't updated when the type of > its return value was changed. Yes. I didn't even look in config/*.exp when I changed the return type of gdb_file_cmd and gdb_load. I thought there was one implementation of gdb_load, but actually, there are nine implementations! I've thought about this and I've decided to revert the return type change. After that, I'll change gdb_file_cmd to set a global variable, which gdb.gdb/*.exp will test. So I'm declining this patch. I'll have the breakage fixed shortly, and then add the new global. Michael > 2004-09-08 Jim Blandy > > * config/sim.exp (gdb_load): Adapt to expect and return new return > values from gdb_file_command.