Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: RFA: adapt gdb/testsuite/config/sim.exp to new gdb_file_cmd
Date: Wed, 08 Sep 2004 23:24:00 -0000	[thread overview]
Message-ID: <vt2y8jkuyz1.fsf@zenia.home> (raw)


Here's a caller of gdb_file_cmd that wasn't updated when the type of
its return value was changed.

Tested on i686-pc-linux-gnu x powerpc-eabispe sim.

2004-09-08  Jim Blandy  <jimb@redhat.com>

	* config/sim.exp (gdb_load): Adapt to expect and return new return
	values from gdb_file_command.

Index: gdb/testsuite/config/sim.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/config/sim.exp,v
retrieving revision 1.2
diff -c -p -r1.2 sim.exp
*** gdb/testsuite/config/sim.exp	8 Feb 2004 03:56:14 -0000	1.2
--- gdb/testsuite/config/sim.exp	8 Sep 2004 23:22:12 -0000
*************** proc gdb_target_sim { } {
*** 46,52 ****
  
  #
  # gdb_load -- load a file into the debugger.
- #             return a -1 if anything goes wrong.
  #
  proc gdb_load { arg } {
      global verbose
--- 46,51 ----
*************** proc gdb_load { arg } {
*** 56,62 ****
      global gdb_prompt
  
      if { $arg != "" } {
! 	if [gdb_file_cmd $arg] then { return -1 }
      }
  
      gdb_target_sim
--- 55,64 ----
      global gdb_prompt
  
      if { $arg != "" } {
!         set status [gdb_file_cmd $arg]
!         if { [lindex $status 0] != "" } then {
!             return $status
!         }
      }
  
      gdb_target_sim
*************** proc gdb_load { arg } {
*** 71,77 ****
  	    }
  	    set timeout 30
  	    verbose "Timeout is now $timeout seconds" 2
! 	    return 1
  	}
  	-re "$gdb_prompt $"     {
  	    if $verbose>1 then {
--- 73,79 ----
  	    }
  	    set timeout 30
  	    verbose "Timeout is now $timeout seconds" 2
! 	    return { "" }
  	}
  	-re "$gdb_prompt $"     {
  	    if $verbose>1 then {


             reply	other threads:[~2004-09-08 23:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-08 23:24 Jim Blandy [this message]
2004-09-09 17:33 ` Michael Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2y8jkuyz1.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox