From: Michael Chastain <mec.gnu@mindspring.com>
To: manjo@austin.ibm.com, gdb-patches@sources.redhat.com
Subject: Re: [RFC] changes to gdb.gdb to use new gdb.exp
Date: Wed, 01 Sep 2004 19:38:00 -0000 [thread overview]
Message-ID: <41362545.nail1N2289W8N@mindspring.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0409011150491.30693@lazy>
All right. This patch is approved, after some formatting changes to
the ChangeLog entry.
Your entry:
2004-09-01 Manoj Iyer <manjo@austin.ibm.com
* gdb.gdb/complaints.exp (setup_test): use new gdb.exp functionality
to check for nodebug in executable.
* gdb.gdb/observer.exp (setup_test): use new gdb.exp functionality
to check for nodebug in executable.
* gdb.gdb/selftest.exp (test_with_self): use new gdb.exp functionality
to check for nodebug in executable.
* gdb.gdb/xfullpath.exp (setup_test): use new gdb.exp functionality
to check for nodebug in executable.
Change it to:
2004-09-01 Manoj Iyer <manjo@austin.ibm.com>
* gdb.gdb/complaints.exp (setup_test): Use new gdb.exp functionality
to check for nodebug in executable.
* gdb.gdb/observer.exp (setup_test): Likewise.
* gdb.gdb/selftest.exp (test_with_self): Likewise.
* gdb.gdb/xfullpath.exp (setup_test): Likewise.
. Typo on email address.
. Capitalize the sentence "Use new gdb.exp functionality ..."
. Use "Likewise" to make it easier to read.
We're picky about ChangeLog formatting because some people have emacs
macros and stuff that scan ChangeLog files.
With that ChangeLog entry, your patch is approved. Thanks!
Michael
next prev parent reply other threads:[~2004-09-01 19:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-31 20:38 Manoj Iyer
2004-09-01 16:38 ` Michael Chastain
2004-09-01 17:44 ` Manoj Iyer
2004-09-01 19:38 ` Michael Chastain [this message]
2004-09-02 1:27 ` [COMMIT] " Manoj Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41362545.nail1N2289W8N@mindspring.com \
--to=mec.gnu@mindspring.com \
--cc=gdb-patches@sources.redhat.com \
--cc=manjo@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox