From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30673 invoked by alias); 1 Sep 2004 19:38:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30666 invoked from network); 1 Sep 2004 19:38:50 -0000 Received: from unknown (HELO blount.mail.mindspring.net) (207.69.200.226) by sourceware.org with SMTP; 1 Sep 2004 19:38:50 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by blount.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1C2awN-0000Ff-00; Wed, 01 Sep 2004 15:38:43 -0400 Received: from mindspring.com (localhost [127.0.0.1]) by berman.michael-chastain.com (Postfix) with SMTP id 8A6314B102; Wed, 1 Sep 2004 15:38:47 -0400 (EDT) Date: Wed, 01 Sep 2004 19:38:00 -0000 From: Michael Chastain To: manjo@austin.ibm.com, gdb-patches@sources.redhat.com Subject: Re: [RFC] changes to gdb.gdb to use new gdb.exp Message-ID: <41362545.nail1N2289W8N@mindspring.com> References: <4135FAAA.nail59915B4OV@mindspring.com> In-Reply-To: User-Agent: nail 10.8 6/28/04 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00022.txt.bz2 All right. This patch is approved, after some formatting changes to the ChangeLog entry. Your entry: 2004-09-01 Manoj Iyer * gdb.gdb/complaints.exp (setup_test): Use new gdb.exp functionality to check for nodebug in executable. * gdb.gdb/observer.exp (setup_test): Likewise. * gdb.gdb/selftest.exp (test_with_self): Likewise. * gdb.gdb/xfullpath.exp (setup_test): Likewise. . Typo on email address. . Capitalize the sentence "Use new gdb.exp functionality ..." . Use "Likewise" to make it easier to read. We're picky about ChangeLog formatting because some people have emacs macros and stuff that scan ChangeLog files. With that ChangeLog entry, your patch is approved. Thanks! Michael