Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Chastain <mec.gnu@mindspring.com>
To: manjo@austin.ibm.com, gdb-patches@sources.redhat.com
Subject: Re: [RFC] changes to gdb.gdb to use new gdb.exp
Date: Wed, 01 Sep 2004 16:38:00 -0000	[thread overview]
Message-ID: <4135FAAA.nail59915B4OV@mindspring.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0408311500250.19258@lazy>

Hi Manoj,

Three things:

. Use "lsearch" rather than "lindex".  The spec for gdb_file_cmd says
  that it can return several words after the MESSAGE.  So something
  like:

    if { [lsearch -exact [lrange $result 1 end] "nodebug"] >= 0 }

  That way, the caller will keep working after gdb_file_cmd adds more words.

. Include a ChangeLog entry with the patch.

. Say what system you tested the patch on, and how you tested it.

Michael


  reply	other threads:[~2004-09-01 16:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-31 20:38 Manoj Iyer
2004-09-01 16:38 ` Michael Chastain [this message]
2004-09-01 17:44   ` Manoj Iyer
2004-09-01 19:38     ` Michael Chastain
2004-09-02  1:27       ` [COMMIT] " Manoj Iyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4135FAAA.nail59915B4OV@mindspring.com \
    --to=mec.gnu@mindspring.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=manjo@austin.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox