From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23130 invoked by alias); 1 Sep 2004 16:38:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23096 invoked from network); 1 Sep 2004 16:38:14 -0000 Received: from unknown (HELO tisch.mail.mindspring.net) (207.69.200.157) by sourceware.org with SMTP; 1 Sep 2004 16:38:14 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by tisch.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1C2Y73-0002Xl-00; Wed, 01 Sep 2004 12:37:33 -0400 Received: from mindspring.com (localhost [127.0.0.1]) by berman.michael-chastain.com (Postfix) with SMTP id D25644B102; Wed, 1 Sep 2004 12:37:12 -0400 (EDT) Date: Wed, 01 Sep 2004 16:38:00 -0000 From: Michael Chastain To: manjo@austin.ibm.com, gdb-patches@sources.redhat.com Subject: Re: [RFC] changes to gdb.gdb to use new gdb.exp Message-ID: <4135FAAA.nail59915B4OV@mindspring.com> References: In-Reply-To: User-Agent: nail 10.8 6/28/04 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00013.txt.bz2 Hi Manoj, Three things: . Use "lsearch" rather than "lindex". The spec for gdb_file_cmd says that it can return several words after the MESSAGE. So something like: if { [lsearch -exact [lrange $result 1 end] "nodebug"] >= 0 } That way, the caller will keep working after gdb_file_cmd adds more words. . Include a ChangeLog entry with the patch. . Say what system you tested the patch on, and how you tested it. Michael