[RFC] gdb_ptrace.h

[RFC] gdb_ptrace.h

[Mark Kettenis]

There are several places where we need symbolic constants from
<sys/ptrace.h>.  Since these are not provided on all systems, I
propose to add the file attached to this message.  Using this file
leads to some simplifications in several source files.

Comments?

Mark


/* Portable <sys/ptrace.h>

   Copyright 2004 Free Software Foundation, Inc.

   This file is part of GDB.

   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
   the Free Software Foundation; either version 2 of the License, or
   (at your option) any later version.

   This program is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
   GNU General Public License for more details.

   You should have received a copy of the GNU General Public License
   along with this program; if not, write to the Free Software
   Foundation, Inc., 59 Temple Place - Suite 330,
   Boston, MA 02111-1307, USA.  */
   
#ifndef GDB_PTRACE_H
#define GDB_PTRACE_H

/* The <sys/ptrace.h> header was introduced with 4.4BSD, and provided
   the PT_* symbolic constants for the ptrace(2) request numbers.  The
   ptrace(2) prototype was added later to the same header on BSD.
   SunOS and Linux have slightly different symbolic names for the
   constants that start with PTRACE_*.  System V still doesn't have
   (and probably never will have) a <sys/ptrace.h> with symbolic
   constants; the ptrace(2) prototype can be found in <unistd.h>.
   Fortunately all systems use the same numerical constants for the
   common ptrace requests.  */

#ifdef HAVE_PTRACE_H
# include <ptrace.h>
#else
#ifdef HAVE_SYS_PTRACE_H
# include <sys/ptrace.h>
#endif
#endif

/* No need to include <unistd.h> since it's already included by
   "defs.h".  */

#ifndef PT_READ_I
# define PT_READ_I	1	/* Read word in child's I space.  */
#endif

#ifndef PT_READ_D
# define PT_READ_D	2	/* Read word in child's D space.  */
#endif

#ifndef PT_READ_U
# define PT_READ_U	3	/* Read word in child's U space.  */
#endif

#ifndef PT_WRITE_I
# define PT_WRITE_I	4	/* Write word in child's I space.  */
#endif

#ifndef PT_WRITE_D
# define PT_WRITE_D	5	/* Write word in child's I space.  */
#endif

#ifndef PT_WRITE_U
# define PT_WRITE_U	6	/* Write word in child's I space.  */
#endif

/* HP-UX doesn't define PT_CONTINUE and PT_STEP.  Instead of those two
   ptrace requests, it has PT_CONTIN, PT_CONTIN1, PT_SINGLE and
   PT_SINGLE1.  PT_CONTIN1 and PT_SINGLE1 preserve pending signals,
   which apparently is what is wanted by the HP-UX native code.  */

#ifndef PT_CONTINUE
# ifdef PT_CONTIN1
#  define PT_CONTINUE	PT_CONTIN1
# else
#  define PT_CONTINUE	7	/* Continue the child.  */
# endif
#endif

#ifndef PT_KILL
# define PT_KILL	8	/* Kill the child process.  */
#endif

#ifndef PT_STEP
# ifdef PT_SINGLE1
#  define PT_STEP	PT_SINGLE1
# else
#  define PT_STEP	9	/* Single step the child.   */
# endif
#endif

/* Not all systems support attaching and detaching.   */

#ifndef PT_ATTCH
# ifdef PTRACE_DETACH
#  define PT_ATTACH PTRACE_ATTACH
# endif
#endif

#ifndef PT_DETACH
# ifdef PTRACE_DETACH
#  define PT_DETACH PTRACE_DETACH
# endif
#endif

#endif /* gdb_ptrace.h */

Re: [RFC] gdb_ptrace.h

[Michael Chastain]

Mark Kettenis <kettenis@chello.nl> wrote:

One nit -- in the comment about HP-UX, specify which version number
(HP-UX 10.20 or HP-UX 11.00 or HP-UX 11.11).

Other than that, I'm too tired to have a useful opinion.  :-/

Michael

Re: [RFC] gdb_ptrace.h

[Mark Kettenis]

   Date: Fri, 13 Aug 2004 18:09:41 -0400
   From: Michael Chastain <mec.gnu@mindspring.com>

   Mark Kettenis <kettenis@chello.nl> wrote:

   One nit -- in the comment about HP-UX, specify which version number
   (HP-UX 10.20 or HP-UX 11.00 or HP-UX 11.11).

All three of them, and hopefully everything before 10.20 too.  That's
why I think HP-UX without a version number is more appropriate.

Cheers,

Mark

Re: [RFC] gdb_ptrace.h

[Michael Chastain]

Mark Kettenis <kettenis@chello.nl> wrote:
> All three of them, and hopefully everything before 10.20 too.  That's
> why I think HP-UX without a version number is more appropriate.

But then someone comes along in 2006 and wonders whether it applies to
hpux 11.23 or not.  That's why I like to use version numbers when I've
observed something.  -- Just my opinion, though.

Re: [RFC] gdb_ptrace.h

[Andrew Cagney]

> Mark Kettenis <kettenis@chello.nl> wrote:
> 
>>> All three of them, and hopefully everything before 10.20 too.  That's
>>> why I think HP-UX without a version number is more appropriate.
> 
> 
> But then someone comes along in 2006 and wonders whether it applies to
> hpux 11.23 or not.  That's why I like to use version numbers when I've
> observed something.  -- Just my opinion, though.

Right, we should at least explicitly list the systems on which we've 
confirmed the assertion.

Andrew