Re: RFA/RFC: Change Sparc64 gdb.asm tests to use -gdwarf2 instead of -gstabs

[Nick Clifton <nickc@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]

Hi Mark,

> Not all right!  Nick, did you actually test this patch?  The subject
> of this thread is making sparc64 use -gdwarf2 instead of -gstabs, but
> the patch changes it to -gdwarf-2 (note the extra dash).  This isn't
> accepted by gas on my OpenBSD/amd64 and OpenBSD/sparc64 systems, and
> AFAICT it isn't accepted by the current gas from CVS either.

I did test the patch - but unfortuntately I tested is against a GAS 
built from the CVS sources with a few, work-in-progress, modifications 
of my own applied - including one that supports -gdwarf-2 so that GAS 
would be consistent with the same switches supported by GCC.

I am very sorry about this mistake - I should have used a pristeen 
version of GAS.

I would like to apply the patch below to rectify this problem.  Tested 
with an x86 native host and an sh-elf cross compiler.  Is this OK ?

Cheers
   Nick

gdb/testsuite/ChangeLog
2004-07-30  Nick Clifton  <nickc@redhat.com>

	* gdb.asm/asm-source.exp: Fix typo in previous delta: gdwarf-2
	-> gdwarf2.
	Move -gdwarf2 switch from asm-flags to debug-flags for m6811 and
	m6812.

[-- Attachment #2: asm-source.exp.patch --]
[-- Type: text/plain, Size: 4504 bytes --]

Index: gdb/testsuite/gdb.asm/asm-source.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
retrieving revision 1.51
diff -c -3 -p -r1.51 asm-source.exp
*** gdb/testsuite/gdb.asm/asm-source.exp	27 Jul 2004 09:28:42 -0000	1.51
--- gdb/testsuite/gdb.asm/asm-source.exp	30 Jul 2004 11:47:53 -0000
*************** switch -glob -- [istarget] {
*** 43,49 ****
  	# ??? Won't work with ecoff systems like Tru64, but then we also
  	# don't have any other -g flag that creates mdebug output.
          set asm-flags "-no-mdebug -I${srcdir}/${subdir} -I${objdir}/${subdir}"
! 	set debug-flags "-gdwarf-2"
      }
      "*arm-*-*" {
          set asm-arch arm
--- 43,49 ----
  	# ??? Won't work with ecoff systems like Tru64, but then we also
  	# don't have any other -g flag that creates mdebug output.
          set asm-flags "-no-mdebug -I${srcdir}/${subdir} -I${objdir}/${subdir}"
! 	set debug-flags "-gdwarf2"
      }
      "*arm-*-*" {
          set asm-arch arm
*************** switch -glob -- [istarget] {
*** 66,72 ****
      "x86_64-*-*" {
          set asm-arch x86_64
          set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}"
! 	set debug-flags "-gdwarf-2"
      }
      "i\[3456\]86-*-*" {
          set asm-arch i386
--- 66,72 ----
      "x86_64-*-*" {
          set asm-arch x86_64
          set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}"
! 	set debug-flags "-gdwarf2"
      }
      "i\[3456\]86-*-*" {
          set asm-arch i386
*************** switch -glob -- [istarget] {
*** 77,87 ****
      }
      "m6811-*-*" {
          set asm-arch m68hc11
!         set asm-flags "-mshort-double -m68hc11 -gdwarf2 --no-warn -I${srcdir}/${subdir} -I${objdir}/${subdir}"
      }
      "m6812-*-*" {
          set asm-arch m68hc11
!         set asm-flags "-mshort-double -m68hc12 -gdwarf2 --no-warn -I${srcdir}/${subdir} -I${objdir}/${subdir}"
      }
      "mips*-*" {
          set asm-arch mips
--- 77,89 ----
      }
      "m6811-*-*" {
          set asm-arch m68hc11
!         set asm-flags "-mshort-double -m68hc11 --no-warn -I${srcdir}/${subdir} -I${objdir}/${subdir}"
! 	set debug-flags "-gdwarf2"
      }
      "m6812-*-*" {
          set asm-arch m68hc11
!         set asm-flags "-mshort-double -m68hc12 --no-warn -I${srcdir}/${subdir} -I${objdir}/${subdir}"
! 	set debug-flags "-gdwarf2"
      }
      "mips*-*" {
          set asm-arch mips
*************** switch -glob -- [istarget] {
*** 92,98 ****
      "sh*-*-*" {
          set asm-arch sh
          set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}"
! 	set debug-flags "-gdwarf-2"
      }
      "sparc-*-*" {
          set asm-arch sparc
--- 94,100 ----
      "sh*-*-*" {
          set asm-arch sh
          set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}"
! 	set debug-flags "-gdwarf2"
      }
      "sparc-*-*" {
          set asm-arch sparc
*************** switch -glob -- [istarget] {
*** 100,111 ****
      "sparc64-*-*" {
          set asm-arch sparc64
          set asm-flags "-xarch=v9 -I${srcdir}/${subdir} -I${objdir}/${subdir}"
! 	set debug-flags "-gdwarf-2"
      }
      "xstormy16-*-*" {
          set asm-arch xstormy16
          set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}"
! 	set debug-flags "-gdwarf-2"
      }
      "v850-*-*" {
          set asm-arch v850
--- 102,113 ----
      "sparc64-*-*" {
          set asm-arch sparc64
          set asm-flags "-xarch=v9 -I${srcdir}/${subdir} -I${objdir}/${subdir}"
! 	set debug-flags "-gdwarf2"
      }
      "xstormy16-*-*" {
          set asm-arch xstormy16
          set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}"
! 	set debug-flags "-gdwarf2"
      }
      "v850-*-*" {
          set asm-arch v850
*************** switch -glob -- [istarget] {
*** 117,128 ****
      "ia64-*-*" {
          set asm-arch ia64
          set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}"
! 	set debug-flags "-gdwarf-2"
      }
      "hppa*-linux-*" {
          set asm-arch pa
          set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}"
! 	set debug-flags "-gdwarf-2"
      }
  }
  
--- 119,130 ----
      "ia64-*-*" {
          set asm-arch ia64
          set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}"
! 	set debug-flags "-gdwarf2"
      }
      "hppa*-linux-*" {
          set asm-arch pa
          set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}"
! 	set debug-flags "-gdwarf2"
      }
  }