Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Chastain <mec.gnu@mindspring.com>
To: nickc@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA/RFC: Change Sparc64 gdb.asm tests to use -gdwarf2 instead of  -gstabs
Date: Mon, 26 Jul 2004 23:55:00 -0000	[thread overview]
Message-ID: <41059A05.nailMF911EDIR@mindspring.com> (raw)
In-Reply-To: <41054231.7010006@redhat.com>

All right!  This patch is approved.

> AFAIK there is no such bug report.  Although there is a related one 
> about the generation of aligned and unaligned relocs for the Sparc.

Then the test can continue to FAIL until someone files a bug report
for it, or just fixes it, or maybe makes it UNSUPPORTED.  That's okay.

> OK I ran those tests, although I changed the flags to be "-gdwarf2" and 
> "-gstabs+".  I also added "gdb.asm/asm-source.exp" to the command lines, 
> since I assumed that it was OK to just run the assembler tests.  The 
> patch does not affect any other part of the GDB testsuite.

Err right, my sample code was bad.  Yeah, it's okay to just test
asm-source.exp.

> I ran the tests on an x86 native host and a Sparc64 native host, just to 
> make sure that the default selection code worked as well.  There was 
> only one combination that produced any failures:
>
>    Sparc64 native with -gstabs+

Beautiful, that's what I'm looking for.

Now the next poor hacker who ventures into asm-source.exp will have
something to read when they say "what is this ... let me check the
mailing list archives ...".

Michael C

===

2004-07-26  Nick Clifton  <nickc@redhat.com>

	* gdb.asm/asm-source.exp (debug-flags): New variable.  If a
	known good default value for a specific architecture is
	available then set it to that value.  Otherwise default to the
	-gstabs switch.  Remove the -g... switches from the asm-flags
	variable.  Allow the target board info to override the value if
	it wants to.  Pass the switch on the assembler command line.


  reply	other threads:[~2004-07-26 23:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-26 12:59 Nick Clifton
     [not found] ` <41051014 dot nailLY111456S at mindspring dot com>
2004-07-26 14:07 ` Michael Chastain
2004-07-26 17:31   ` Nick Clifton
2004-07-26 23:55     ` Michael Chastain [this message]
2004-07-29 23:03       ` Mark Kettenis
2004-07-29 23:38         ` Michael Chastain
2004-07-30  0:07           ` Mark Kettenis
2004-07-30 11:55         ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41059A05.nailMF911EDIR@mindspring.com \
    --to=mec.gnu@mindspring.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox